path: root/src/intel/isl
diff options
authorTopi Pohjolainen <>2017-07-18 17:06:07 +0300
committerTopi Pohjolainen <>2017-07-22 00:14:16 +0300
commitdf9bb8dc059a3cdb0a2099deb25cb4292e301933 (patch)
treefae29a9bd7382afce29740e2a2b92ecd989e4497 /src/intel/isl
parentabb84e3f2da47d69b5211d838b10b155f590acc0 (diff)
intel/isl/gen7: Allow msaa with signed integer formats
These formats are already allowed by the i965 GL driver, and the feature seems to work just fine. There are tests for multisampled rendering in piglit: tests/spec/ext_framebuffer_multisample which can be patched to try 16I/32I in addition to GL_RGBA8I. IvyBridge passed all tests with all sample numbers. Reviewed-by: Jason Ekstrand <> Signed-off-by: Topi Pohjolainen <>
Diffstat (limited to 'src/intel/isl')
1 files changed, 3 insertions, 2 deletions
diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c
index 4c5edb4b93c..ab47a7f6229 100644
--- a/src/intel/isl/isl_gen7.c
+++ b/src/intel/isl/isl_gen7.c
@@ -76,9 +76,10 @@ isl_gen7_choose_msaa_layout(const struct isl_device *dev,
* Note that the above SINT restrictions apply only to *MSRTs* (that is,
* *multisampled* render targets). The restrictions seem to permit an MCS
* if the render target is singlesampled.
+ *
+ * Moreover, empirically it looks that hardware can render multisampled
+ * surfaces with RGBA8I, RGBA16I and RGBA32I.
- if (isl_format_has_sint_channel(info->format))
- return false;
/* More obvious restrictions */
if (isl_surf_usage_is_display(info->usage))