path: root/src/intel/isl/isl_format.c
diff options
authorMatt Turner <>2017-07-06 21:19:18 -0700
committerMatt Turner <>2017-08-29 15:20:57 -0700
commit9fdbc273efdf20f325f9711997ae77016f3d4e0a (patch)
treead6292e6f127b931afa1788d84bf40e457214eab /src/intel/isl/isl_format.c
parentcdbaa8a12feff2286b61cecf0b2e5b3feb8d902d (diff)
intel/isl: Remove 'inline' keywords
Unless you have data, the compiler knows better than you whether a function should be inlined. Unlike all other cases in this series, the removal of the inline keyword from isl_format_has_channel_type actually changes the resulting binary with gcc-6.3.0: text data bss dec hex filename 7831116 346384 420648 8598148 833284 before 7830716 346384 420648 8597748 8330f4 after I think this is likely an improvement. No difference in the resulting binary with clang-4.0. Reviewed-by: Emil Velikov <> Reviewed-by: Eric Engestrom <>
Diffstat (limited to 'src/intel/isl/isl_format.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c
index 435b0d003a6..fba3ac5e1ac 100644
--- a/src/intel/isl/isl_format.c
+++ b/src/intel/isl/isl_format.c
@@ -608,7 +608,7 @@ isl_formats_are_ccs_e_compatible(const struct gen_device_info *devinfo,
fmtl1->channels.a.bits == fmtl2->channels.a.bits;
-static inline bool
+static bool
isl_format_has_channel_type(enum isl_format fmt, enum isl_base_type type)
const struct isl_format_layout *fmtl = isl_format_get_layout(fmt);