path: root/src/gallium/drivers
diff options
authorRob Clark <>2019-01-02 11:35:02 -0500
committerRob Clark <>2019-01-03 08:10:32 -0500
commit67a7f6f24433beb5795bea5325700f50d845ed64 (patch)
tree39d64542e3e3170602ff61e658c0ddb8833ec675 /src/gallium/drivers
parent2fc17e16a3f915d5138f43b5cb671b1429b528ec (diff)
freedreno: remove blit_via_copy_region()
If we hit the memcpy() path for copy_region(), that will try to do a transfer_map(), which goes badly for blits to/from staging triggered by transfer_map() or transfer_unmap(). We could possibly add fd_blit2() which has allow_transfer_map param, and call that for staging blits. But I'm not really sure if trying the blit via copy_region() is very useful. At least for newer gens that implement fd_context::blit(), it probably isn't. Signed-off-by: Rob Clark <>
Diffstat (limited to 'src/gallium/drivers')
1 files changed, 0 insertions, 4 deletions
diff --git a/src/gallium/drivers/freedreno/freedreno_resource.c b/src/gallium/drivers/freedreno/freedreno_resource.c
index f1e439b7133..838881cf150 100644
--- a/src/gallium/drivers/freedreno/freedreno_resource.c
+++ b/src/gallium/drivers/freedreno/freedreno_resource.c
@@ -979,10 +979,6 @@ fd_blit(struct pipe_context *pctx, const struct pipe_blit_info *blit_info)
if (info.render_condition_enable && !fd_render_condition_check(pctx))
- if (util_try_blit_via_copy_region(pctx, &info)) {
- return; /* done */
- }
if (info.mask & PIPE_MASK_S) {
DBG("cannot blit stencil, skipping");
info.mask &= ~PIPE_MASK_S;