diff options
| author | Chad Versace <chad.versace@linux.intel.com> | 2012-11-20 13:43:11 -0800 |
|---|---|---|
| committer | Ian Romanick <ian.d.romanick@intel.com> | 2013-01-15 13:45:54 -0800 |
| commit | eb09940e55806c36890ae8f5a35ad1b37ed74832 (patch) | |
| tree | 7880a387e69b81adf77751bb309c9349f8a0a7ae /src/egl/main | |
| parent | 26f9faa04b4e924bc8e1fc35a5d75179063764e6 (diff) | |
egl/dri2: Add plumbing for EGL_OPENGL_ES3_BIT_KHR
Fixes error EGL_BAD_ATTRIBUTE in the tests below on Intel Sandybridge:
* piglit egl-create-context-verify-gl-flavor, testcase OpenGL ES 3.0
* gles3conform, revision 19700, when runnning GL3Tests with -fbo
This plumbing is added in order to comply with the EGL_KHR_create_context
spec. According to the EGL_KHR_create_context spec, it is illegal to call
eglCreateContext(EGL_CONTEXT_MAJOR_VERSION_KHR=3) with a config whose
EGL_RENDERABLE_TYPE does not contain the EGL_OPENGL_ES3_BIT_KHR. The
pertinent
portion of the spec is quoted below; the key word is "respectively".
* If <config> is not a valid EGLConfig, or does not support the
requested client API, then an EGL_BAD_CONFIG error is generated
(this includes requesting creation of an OpenGL ES 1.x, 2.0, or
3.0 context when the EGL_RENDERABLE_TYPE attribute of <config>
does not contain EGL_OPENGL_ES_BIT, EGL_OPENGL_ES2_BIT, or
EGL_OPENGL_ES3_BIT_KHR respectively).
To create this patch, I searched for all the ES2 bit plumbing by calling
`git grep "ES2_BIT\|DRI_API_GLES2" src/egl`, and then at each location
added a case for ES3.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Diffstat (limited to 'src/egl/main')
| -rw-r--r-- | src/egl/main/eglconfig.c | 1 | ||||
| -rw-r--r-- | src/egl/main/eglcontext.c | 4 | ||||
| -rw-r--r-- | src/egl/main/eglcurrent.h | 1 | ||||
| -rw-r--r-- | src/egl/main/eglmisc.c | 3 | ||||
| -rw-r--r-- | src/egl/main/eglsurface.c | 5 |
5 files changed, 12 insertions, 2 deletions
diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c index e1d53da3cd5..b18f30123a9 100644 --- a/src/egl/main/eglconfig.c +++ b/src/egl/main/eglconfig.c @@ -331,6 +331,7 @@ _eglValidateConfig(const _EGLConfig *conf, EGLBoolean for_matching) mask = EGL_OPENGL_ES_BIT | EGL_OPENVG_BIT | EGL_OPENGL_ES2_BIT | + EGL_OPENGL_ES3_BIT_KHR | EGL_OPENGL_BIT; break; default: diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index 4efb76bb986..86af91d7deb 100644 --- a/src/egl/main/eglcontext.c +++ b/src/egl/main/eglcontext.c @@ -54,9 +54,11 @@ _eglGetContextAPIBit(_EGLContext *ctx) bit = EGL_OPENGL_ES_BIT; break; case 2: - case 3: bit = EGL_OPENGL_ES2_BIT; break; + case 3: + bit = EGL_OPENGL_ES3_BIT_KHR; + break; default: break; } diff --git a/src/egl/main/eglcurrent.h b/src/egl/main/eglcurrent.h index a64821eb125..45fcc64aad4 100644 --- a/src/egl/main/eglcurrent.h +++ b/src/egl/main/eglcurrent.h @@ -37,6 +37,7 @@ (EGL_OPENGL_ES_BIT | \ EGL_OPENVG_BIT | \ EGL_OPENGL_ES2_BIT | \ + EGL_OPENGL_ES3_BIT_KHR | \ EGL_OPENGL_BIT) diff --git a/src/egl/main/eglmisc.c b/src/egl/main/eglmisc.c index d445c41810c..92b0eae5f2a 100644 --- a/src/egl/main/eglmisc.c +++ b/src/egl/main/eglmisc.c @@ -140,6 +140,9 @@ _eglUpdateAPIsString(_EGLDisplay *dpy) if (dpy->ClientAPIs & EGL_OPENGL_ES2_BIT) strcat(apis, "OpenGL_ES2 "); + if (dpy->ClientAPIs & EGL_OPENGL_ES3_BIT_KHR) + strcat(apis, "OpenGL_ES3 "); + if (dpy->ClientAPIs & EGL_OPENVG_BIT) strcat(apis, "OpenVG "); diff --git a/src/egl/main/eglsurface.c b/src/egl/main/eglsurface.c index 9fc53674fd0..fa57f833683 100644 --- a/src/egl/main/eglsurface.c +++ b/src/egl/main/eglsurface.c @@ -435,11 +435,14 @@ _eglSurfaceAttrib(_EGLDriver *drv, _EGLDisplay *dpy, _EGLSurface *surface, { EGLint confval; EGLint err = EGL_SUCCESS; + EGLint all_es_bits = EGL_OPENGL_ES_BIT | + EGL_OPENGL_ES2_BIT | + EGL_OPENGL_ES3_BIT_KHR; switch (attribute) { case EGL_MIPMAP_LEVEL: confval = surface->Config->RenderableType; - if (!(confval & (EGL_OPENGL_ES_BIT | EGL_OPENGL_ES2_BIT))) { + if (!(confval & all_es_bits)) { err = EGL_BAD_PARAMETER; break; } |