diff options
| author | Rob Clark <robclark@freedesktop.org> | 2014-05-04 10:40:46 -0400 |
|---|---|---|
| committer | Carl Worth <cworth@cworth.org> | 2014-07-03 21:25:50 -0700 |
| commit | ff9cea87762aec989f9e860f0856075e6841e264 (patch) | |
| tree | dd3e7cd4bfcb457f95eb8cfb0a3e248732b22796 | |
| parent | 95ff8c6f18f218b56f6735079a3e7716ce83ddf5 (diff) | |
xa: fix segfault
Fixes:
Program received signal SIGSEGV, Segmentation fault.
bind_samplers (comp=0x21b054, comp=0x21b054, ctx=0x211430)
at ../../../../../src/gallium/state_trackers/xa/xa_composite.c:445
445 mask_pic->srf->tex->format);
(gdb) bt
#0 bind_samplers (comp=0x21b054, comp=0x21b054, ctx=0x211430)
at ../../../../../src/gallium/state_trackers/xa/xa_composite.c:445
#1 xa_composite_prepare (ctx=0x211430, comp=comp@entry=0x21b054)
at ../../../../../src/gallium/state_trackers/xa/xa_composite.c:488
#2 0xb6f454b4 in XAPrepareComposite (op=<optimized out>, pSrcPicture=<optimized out>,
pMaskPicture=<optimized out>, pDstPicture=<optimized out>, pSrc=0x5b3ad8, pMask=0x0,
pDst=0x5923b8) at msm-exa-xa.c:533
We can't yet handle solid fill mask, so explicitly reject that, rather
than segfaulting. Otherwise DDX would need to check XA version to see
if solid fill mask were supported.
Signed-off-by: Rob Clark <robclark@freedesktop.org>
(cherry picked from commit b7e7ae9f605283076dba6d9e826fbbd1f1db1c4b)
| -rw-r--r-- | src/gallium/state_trackers/xa/xa_composite.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/gallium/state_trackers/xa/xa_composite.c b/src/gallium/state_trackers/xa/xa_composite.c index 7ae35a160e5..c283a0d1892 100644 --- a/src/gallium/state_trackers/xa/xa_composite.c +++ b/src/gallium/state_trackers/xa/xa_composite.c @@ -472,6 +472,9 @@ xa_composite_prepare(struct xa_context *ctx, struct xa_surface *dst_srf = comp->dst->srf; int ret; + if (comp->mask && !comp->mask->srf) + return -XA_ERR_INVAL; + ret = xa_ctx_srf_create(ctx, dst_srf); if (ret != XA_ERR_NONE) return ret; |