diff options
| author | Ian Romanick <ian.d.romanick@intel.com> | 2020-07-30 11:33:03 -0700 |
|---|---|---|
| committer | Dylan Baker <dylan.c.baker@intel.com> | 2020-11-20 12:37:34 -0800 |
| commit | 43697f6c5fc94c8f0a45b9d73c47e26ab2dd9083 (patch) | |
| tree | 60815f53516396d73d3639e863e0c4014f44a95b | |
| parent | 2d1e15236b0296774b2a64b9536b5925b184462b (diff) | |
intel/compiler: Rotate instructions ROR and ROL cannot have source modifiers
I checked the Bspec for both Gen11 and Gen12, and it appears that rotate
instructions cannot have source modifiers or saturate modifer. Saturate
was already handled.
Fixes: 1e92e83856b ("intel/compiler: Emit ROR and ROL instruction")
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7650>
(cherry picked from commit 6edc2a3d40406f5b0a5edd5bcccd3232ad50a61f)
| -rw-r--r-- | .pick_status.json | 2 | ||||
| -rw-r--r-- | src/intel/compiler/brw_shader.cpp | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/.pick_status.json b/.pick_status.json index 85306b07c1b..87bdb7e30c6 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -274,7 +274,7 @@ "description": "intel/compiler: Rotate instructions ROR and ROL cannot have source modifiers", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": "1e92e83856b1ef8a827a63359d59ed7883ed4994" }, diff --git a/src/intel/compiler/brw_shader.cpp b/src/intel/compiler/brw_shader.cpp index dbe28748508..cfb2cf54f9c 100644 --- a/src/intel/compiler/brw_shader.cpp +++ b/src/intel/compiler/brw_shader.cpp @@ -937,6 +937,8 @@ backend_instruction::can_do_source_mods() const case BRW_OPCODE_CBIT: case BRW_OPCODE_FBH: case BRW_OPCODE_FBL: + case BRW_OPCODE_ROL: + case BRW_OPCODE_ROR: case BRW_OPCODE_SUBB: case SHADER_OPCODE_BROADCAST: case SHADER_OPCODE_CLUSTER_BROADCAST: |