diff options
| author | Vinson Lee <vlee@freedesktop.org> | 2020-10-23 17:32:16 -0700 |
|---|---|---|
| committer | Dylan Baker <dylan.c.baker@intel.com> | 2020-11-19 10:47:37 -0800 |
| commit | 08153eeb7d22846b08dcb5f05adfa842b0ab6a2f (patch) | |
| tree | a2f09650e957b55090cf7cb6e702dbfc50864699 | |
| parent | 06c593be5b0aff4976b504fcf7748dff6e58c7a5 (diff) | |
amd/addrlib: Add missing va_end.
Fix defect reported by Coverity Scan.
Missing varargs init or cleanup (VARARGS)
missing_va_end: va_end was not called for debugPrintInput.ap.
Fixes: 69ea473eeb91 ("amd/addrlib: update to the latest version")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7299>
(cherry picked from commit c8630fd1143f055249a35877aa056878e56d00c3)
| -rw-r--r-- | .pick_status.json | 2 | ||||
| -rw-r--r-- | src/amd/addrlib/src/core/addrobject.cpp | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/.pick_status.json b/.pick_status.json index 3479403b52b..5ff665fe9b9 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -3919,7 +3919,7 @@ "description": "amd/addrlib: Add missing va_end.", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": "69ea473eeb91b2c4db26402c3bc2ed5799d26605" }, diff --git a/src/amd/addrlib/src/core/addrobject.cpp b/src/amd/addrlib/src/core/addrobject.cpp index d148d2f5646..339be4e702a 100644 --- a/src/amd/addrlib/src/core/addrobject.cpp +++ b/src/amd/addrlib/src/core/addrobject.cpp @@ -230,6 +230,7 @@ VOID Object::DebugPrint( m_client.callbacks.debugPrint(&debugPrintInput); va_end(ap); + va_end(debugPrintInput.ap); } #endif } |