summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>2019-05-16 16:59:46 +0100
committerJuan A. Suarez Romero <jasuarez@igalia.com>2019-05-23 08:50:11 +0000
commitce2d68aaceeec30db9128312384e01206d21d1d9 (patch)
treeb8260c9f8972cac6d2a07088f8d941134e809fce
parentc1d83ae9fb12ba55b5781cc562fd730246454815 (diff)
vulkan/overlay: fix timestamp query emission with no pipeline stats
The if (!pipe && timestamp) logic was broken. It should have been : if (!pipe && !timestamp) Let just drop this condition as the following code does the right thing for all cases. An error was appearing with the following variables : VK_INSTANCE_LAYERS=VK_LAYER_MESA_overlay VK_LAYER_MESA_OVERLAY_CONFIG=gpu_timing Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: ea7a6fa98055ad ("vulkan/overlay: add pipeline statistic & timestamps support") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> (cherry picked from commit 213d6527d49aeafe28d2bd320ad462730e0d56eb)
-rw-r--r--src/vulkan/overlay-layer/overlay.cpp4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/vulkan/overlay-layer/overlay.cpp b/src/vulkan/overlay-layer/overlay.cpp
index 7d24c64886e..5b761eefc8a 100644
--- a/src/vulkan/overlay-layer/overlay.cpp
+++ b/src/vulkan/overlay-layer/overlay.cpp
@@ -1893,10 +1893,6 @@ static VkResult overlay_BeginCommandBuffer(
return result;
}
- /* Primary command buffers with no queries. */
- if (!cmd_buffer_data->pipeline_query_pool && cmd_buffer_data->timestamp_query_pool)
- return device_data->vtable.BeginCommandBuffer(commandBuffer, pBeginInfo);
-
/* Otherwise record a begin query as first command. */
VkResult result = device_data->vtable.BeginCommandBuffer(commandBuffer, pBeginInfo);