diff options
| author | Ernestas Kulik <ernestas.kulik@gmail.com> | 2018-08-30 19:02:46 +0300 |
|---|---|---|
| committer | Dylan Baker <dylan@pnwbakers.com> | 2019-01-31 11:12:29 -0800 |
| commit | c824f8031cee0f4be10943438ffa264fd09ac4e4 (patch) | |
| tree | 0dbc05e5520d2650a08cb0225847df0c939dff23 | |
| parent | 7fdb08375f7091284778668f6ecf0d9304e0dc24 (diff) | |
v3d: Fix leak in resource setup error path
Reported by Coverity: in the case of unsupported modifier request, the
code does not jump to the “fail” label to destroy the acquired resource.
CID: 1435704
Signed-off-by: Ernestas Kulik <ernestas.kulik@gmail.com>
Fixes: 45bb8f295710 ("broadcom: Add V3D 3.3 gallium driver called "vc5", for BCM7268.")
(cherry picked from commit 90458bef544ac46a912f06e73f71c3cb20fdaaf6)
| -rw-r--r-- | src/gallium/drivers/v3d/v3d_resource.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/drivers/v3d/v3d_resource.c b/src/gallium/drivers/v3d/v3d_resource.c index 21c68942e14..84e86799d5e 100644 --- a/src/gallium/drivers/v3d/v3d_resource.c +++ b/src/gallium/drivers/v3d/v3d_resource.c @@ -780,7 +780,7 @@ v3d_resource_create_with_modifiers(struct pipe_screen *pscreen, rsc->tiled = false; } else { fprintf(stderr, "Unsupported modifier requested\n"); - return NULL; + goto fail; } rsc->internal_format = prsc->format; |