summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>2018-04-25 10:56:15 +0200
committerDylan Baker <dylan@pnwbakers.com>2018-04-27 10:11:58 -0700
commit6278c88395622f3a5fba22ed211fa90254fa3cfb (patch)
tree81564a7e90b6e6693cd3f81acdf4af75df9e797e
parentf2b72b6fdc13be985c6c797346f62b169ab3a96b (diff)
radv: fix DCC enablement since partial MSAA implementation
dcc_msaa_allowed is always false on GFX9+ and only true on VI if RADV_PERFTEST=dccmsaa is set. This means DCC was disabled in some situations where it should not. This is likely going to fix a performance regression. Fixes: 2f63b3dd09 ("radv: enable DCC for MSAA 2x textures on VI under an option") Cc: 18.1 <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit a6fbefa67b5b0ed1ee42a9034ee74dfaed1c389a)
-rw-r--r--src/amd/vulkan/radv_image.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index 348f4c7b34c..793f861f4f6 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -133,12 +133,12 @@ radv_use_dcc_for_image(struct radv_device *device,
if (create_info->scanout)
return false;
- /* FIXME: DCC for MSAA with 4x and 8x samples doesn't work yet. */
- if (pCreateInfo->samples > 2)
- return false;
-
- /* TODO: Enable DCC for MSAA textures. */
- if (!device->physical_device->dcc_msaa_allowed)
+ /* FIXME: DCC for MSAA with 4x and 8x samples doesn't work yet, while
+ * 2x can be enabled with an option.
+ */
+ if (pCreateInfo->samples > 2 ||
+ (pCreateInfo->samples == 2 &&
+ !device->physical_device->dcc_msaa_allowed))
return false;
/* Determine if the formats are DCC compatible. */