diff options
authorKenneth Graunke <>2014-02-05 21:42:00 -0800
committerIan Romanick <>2014-02-07 17:10:10 -0800
commitecaf9259e92b22f5f219fc050337336abae642fb (patch)
parent0fb761b404c01e3c026d4774f667ac968a965ccf (diff)
glsl: Don't lose precision qualifiers when encountering "centroid".
Mesa fails to retain the precision qualifier when parsing: #version 300 es centroid in mediump vec2 v; Consider how the parser's type_qualifier production is applied. First, the precision_qualifier rule creates a new ast_type_qualifier: <precision: mediump> Then the storage_qualifier rule creates a second one: <flags: in> and calls merge_qualifier() to fold in any previous qualifications, returning: <flags: in, precision: mediump> Finally, the auxiliary_storage_qualifier creates one for "centroid": <flags: centroid> it then does $$ = $1 and $$.flags |= $2.flags, resulting in: <flags: centroid, in> Since precision isn't stored in the flags bitfield, it is lost. We need to instead call merge_qualifier to combine all the fields. Cc: Signed-off-by: Kenneth Graunke <> Reported-by: Kevin Rogovin <> Reviewed-by: Matt Turner <> Reviewed-by: Ian Romanick <> (cherry picked from commit 2062f40d81de4743758851b03dad506f9cb6f306)
1 files changed, 1 insertions, 1 deletions
diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
index 928c57e20d1..f939fe84316 100644
--- a/src/glsl/glsl_parser.yy
+++ b/src/glsl/glsl_parser.yy
@@ -1466,7 +1466,7 @@ type_qualifier:
"just before storage qualifiers");
$$ = $1;
- $$.flags.i |= $2.flags.i;
+ $$.merge_qualifier(&@1, state, $2);
| storage_qualifier type_qualifier