summaryrefslogtreecommitdiff
path: root/embeddedobj
diff options
context:
space:
mode:
authorIngrid Halama <iha@openoffice.org>2010-08-19 09:18:38 +0200
committerIngrid Halama <iha@openoffice.org>2010-08-19 09:18:38 +0200
commitc9f812ee6706f65a1a41d4b5928b2b1ee0ad5369 (patch)
tree21b249302504d6627425754b9523a457e715bb83 /embeddedobj
parente794eb3b50d14d86f9e24cb598b3c6b16a096005 (diff)
chart49: #i113722# duplicate chart creation - OSingleFactoryHelper::createInstanceWithArgumentsAndContext leak
Diffstat (limited to 'embeddedobj')
-rw-r--r--embeddedobj/source/commonembedding/persistence.cxx6
1 files changed, 3 insertions, 3 deletions
diff --git a/embeddedobj/source/commonembedding/persistence.cxx b/embeddedobj/source/commonembedding/persistence.cxx
index 5cc9c03d8c..75a6e7f962 100644
--- a/embeddedobj/source/commonembedding/persistence.cxx
+++ b/embeddedobj/source/commonembedding/persistence.cxx
@@ -229,11 +229,11 @@ static uno::Reference< util::XCloseable > CreateDocument( const uno::Reference<
}
catch( const uno::Exception& )
{
- // some of our embedded object implementations (in particular chart) do neither support
- // the EmbeddedObject, nor the EmbeddedScriptSupport argument. Also, they do not support
- // XInitialization, which means the default factory from cppuhelper will throw an
+ // if an embedded object implementation does not support XInitialization,
+ // the default factory from cppuhelper will throw an
// IllegalArgumentException when we try to create the instance with arguments.
// Okay, so we fall back to creating the instance without any arguments.
+ OSL_ASSERT("Consider implementing interface XInitialization to avoid duplicate construction");
xDocument = _rxFactory->createInstance( _rDocumentServiceName );
}