summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2011-01-18 10:55:43 +0000
committerCaolán McNamara <caolanm@redhat.com>2011-01-18 10:55:43 +0000
commit89e4950480114e1799984d140b7c5d018687e0ff (patch)
treecb3d1b9e362af2af672b1ef573708f7e5e0f9f30
parentf5671a74eae93bb61b888127ea2bae425e3cfb1d (diff)
cppcheck: pass by reference
-rw-r--r--basic/source/app/dialogs.cxx6
-rw-r--r--basic/source/app/dialogs.hxx2
2 files changed, 4 insertions, 4 deletions
diff --git a/basic/source/app/dialogs.cxx b/basic/source/app/dialogs.cxx
index cf5cfe2973..cf459af392 100644
--- a/basic/source/app/dialogs.cxx
+++ b/basic/source/app/dialogs.cxx
@@ -817,12 +817,12 @@ void GenericOptions::LoadData()
LINK( this, GenericOptions, LoadGroup ).Call( NULL );
}
-void GenericOptions::ShowSelectPath( const String aType )
+void GenericOptions::ShowSelectPath( const String &rType )
{
Point aNPos = aPbNewValue.GetPosPixel();
Point aDPos = aPbDelValue.GetPosPixel();
long nDelta = aDPos.Y() - aNPos.Y();
- if ( aType.EqualsIgnoreCaseAscii( "PATH" ) && !bShowSelectPath )
+ if ( rType.EqualsIgnoreCaseAscii( "PATH" ) && !bShowSelectPath )
{ // Show Path button
nMoveButtons += nDelta;
aMoveTimer.Start();
@@ -830,7 +830,7 @@ void GenericOptions::ShowSelectPath( const String aType )
aPbSelectPath.Show( TRUE );
aPbSelectPath.Enable( TRUE );
}
- else if ( !aType.EqualsIgnoreCaseAscii( "PATH" ) && bShowSelectPath )
+ else if ( !rType.EqualsIgnoreCaseAscii( "PATH" ) && bShowSelectPath )
{ // Hide Path button
nMoveButtons -= nDelta;
aMoveTimer.Start();
diff --git a/basic/source/app/dialogs.hxx b/basic/source/app/dialogs.hxx
index abae90ca6c..48d2d8ccaf 100644
--- a/basic/source/app/dialogs.hxx
+++ b/basic/source/app/dialogs.hxx
@@ -273,7 +273,7 @@ class GenericOptions : public TabPage
StringList* GetAllGroups();
void LoadData();
- void ShowSelectPath( const String aType );
+ void ShowSelectPath( const String& rType );
DECL_LINK( LoadGroup, ComboBox* );
DECL_LINK( DelGroup, Button* );