1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
/*
* This file is part of the LibreOffice project.
*
* Based on LLVM/Clang.
*
* This file is distributed under the University of Illinois Open Source
* License. See LICENSE.TXT for details.
*
*/
/*
This is a rewriter.
Replaces all calls to the deprecated O(U)String::valueOf() .
*/
#include "plugin.hxx"
namespace loplugin
{
class ConvertValueOf
: public RecursiveASTVisitor< ConvertValueOf >
, public RewritePlugin
{
public:
explicit ConvertValueOf( CompilerInstance& compiler, Rewriter& rewriter );
virtual void run() override;
bool VisitCallExpr( const CallExpr* call );
private:
void removeCast( const Expr* arg );
};
ConvertValueOf::ConvertValueOf( CompilerInstance& compiler, Rewriter& rewriter )
: RewritePlugin( compiler, rewriter )
{
}
void ConvertValueOf::run()
{
TraverseDecl( compiler.getASTContext().getTranslationUnitDecl());
}
bool ConvertValueOf::VisitCallExpr( const CallExpr* call )
{
if( ignoreLocation( call ))
return true;
// Using getDirectCallee() here means that we find only calls
// that call the function directly (i.e. not using a pointer, for example).
// Use getCallee() to include also those :
// if( const FunctionDecl* func = dyn_cast_or_null< FunctionDecl >( call->getCalleeDecl()))
if( const FunctionDecl* func = call->getDirectCallee())
{
// Optimize, getQualifiedNameAsString() is reportedly expensive,
// so first check fast details like number of arguments or the (unqualified)
// name before checking the fully qualified name.
// See FunctionDecl for all the API about the function.
if( func->getIdentifier() != NULL
&& ( func->getName() == "valueOf" ))
{
string qualifiedName = func->getQualifiedNameAsString();
if( qualifiedName == "rtl::OString::valueOf" )
{
// Further checks about arguments. Check mainly ParmVarDecl, VarDecl,
// ValueDecl and QualType for Clang API details.
string arg0 = func->getParamDecl( 0 )->getType().getAsString();
if( arg0 == "sal_Bool" )
replaceText( call->getCallee()->getSourceRange(), "OString::boolean" );
else if( arg0 == "sal_Char" )
replaceText( call->getCallee()->getSourceRange(), "OString" );
else
{
replaceText( call->getCallee()->getSourceRange(), "OString::number" );
removeCast( call->getArg( 0 ));
}
}
if( qualifiedName == "rtl::OUString::valueOf" )
{
// Further checks about arguments. Check mainly ParmVarDecl, VarDecl,
// ValueDecl and QualType for Clang API details.
string arg0 = func->getParamDecl( 0 )->getType().getAsString();
if( arg0 == "sal_Bool" )
replaceText( call->getCallee()->getSourceRange(), "OUString::boolean" );
else if( arg0 == "sal_Unicode" )
replaceText( call->getCallee()->getSourceRange(), "OUString" );
else
{
replaceText( call->getCallee()->getSourceRange(), "OUString::number" );
removeCast( call->getArg( 0 ));
}
}
}
}
return true;
}
void ConvertValueOf::removeCast( const Expr* arg )
{
arg = arg->IgnoreImpCasts();
if( const ExplicitCastExpr* cast = dyn_cast< ExplicitCastExpr >( arg ))
{
// Explicit casts don't seem to actually always change the type (integer promotion
// takes place first?), so remove also preceding implicit casts:
// void f( int );
// char a;
// f( int( a ));
// |-CallExpr 0x1a84f20 <line:6:5, col:16> 'void'
// | |-ImplicitCastExpr 0x1a84f08 <col:5> 'void (*)(int)' <FunctionToPointerDecay>
// | | `-DeclRefExpr 0x1a84eb8 <col:5> 'void (int)' lvalue Function 0x1a58900 'f' 'void (int)'
// | `-CXXFunctionalCastExpr 0x1a84e90 <col:8, col:15> 'int' functional cast to int <NoOp>
// | `-ImplicitCastExpr 0x1a84e78 <col:13> 'int' <IntegralCast>
// | `-ImplicitCastExpr 0x1a84e60 <col:13> 'char' <LValueToRValue>
// | `-DeclRefExpr 0x1a58b88 <col:13> 'char' lvalue Var 0x1a58ab0 'a' 'char'
const Expr* castFrom = cast->getSubExpr()->IgnoreImpCasts();
if( cast->getType()->isIntegerType() && castFrom->getType()->isIntegerType())
{
string fromType = castFrom->getType().getAsString();
if( fromType != "sal_Bool" && fromType != "bool" && fromType != "sal_Char" && fromType != "sal_Unicode" )
{
if( const CXXFunctionalCastExpr* funcCast = dyn_cast< CXXFunctionalCastExpr >( cast ))
{
removeText( CharSourceRange::getCharRange( funcCast->getLocStart(),
compiler.getSourceManager().getExpansionLoc( funcCast->getSubExpr()->getLocStart())));
removeText( CharSourceRange::getCharRange( locationAfterToken(
compiler.getSourceManager().getExpansionLoc( funcCast->getSubExpr()->getLocEnd())),
locationAfterToken( funcCast->getLocEnd())));
}
else if( const CXXNamedCastExpr* namedCast = dyn_cast< CXXNamedCastExpr >( cast ))
{
removeText( CharSourceRange::getCharRange( namedCast->getLocStart(),
compiler.getSourceManager().getExpansionLoc( namedCast->getSubExpr()->getLocStart())));
removeText( CharSourceRange::getCharRange( locationAfterToken(
compiler.getSourceManager().getExpansionLoc( namedCast->getSubExpr()->getLocEnd())),
locationAfterToken( namedCast->getLocEnd())));
}
else if( const CStyleCastExpr* cCast = dyn_cast< CStyleCastExpr >( cast ))
removeText( SourceRange( cCast->getLocStart(), cCast->getRParenLoc()));
else
abort();
}
}
}
}
static Plugin::Registration< ConvertValueOf > X( "convertvalueof" );
} // namespace
|
