blob: d445aa250623c301de702cf9102268255af7d609 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include "check.hxx"
#include "plugin.hxx"
// TODO it would be better if we were running some kind of nullability analysis here, where we marked
// the results of expressions like Reference(..UNO_QUERY) as being nullable, and then looked for
// places where we unconditionally deference the results of that expression.
namespace
{
class UnoQuery : public loplugin::FilteringPlugin<UnoQuery>
{
public:
explicit UnoQuery(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitCXXMemberCallExpr(CXXMemberCallExpr const*);
};
bool UnoQuery::VisitCXXMemberCallExpr(CXXMemberCallExpr const* memberCallExpr)
{
if (ignoreLocation(memberCallExpr))
return true;
auto isXInterface = [](Decl const* decl) -> bool {
return bool(loplugin::DeclCheck(decl)
.Class("XInterface")
.Namespace("uno")
.Namespace("star")
.Namespace("sun")
.Namespace("com")
.GlobalNamespace());
};
if (!loplugin::isDerivedFrom(memberCallExpr->getRecordDecl(), isXInterface))
return true;
auto operatorCallExpr = dyn_cast<CXXOperatorCallExpr>(
memberCallExpr->getImplicitObjectArgument()->IgnoreImplicit());
if (!operatorCallExpr)
return true;
Expr const* expr = operatorCallExpr->getArg(0)->IgnoreImplicit();
// depending on the version of clang, the IgnoreImplicit may or may not look through these nodes
if (auto matTemp = dyn_cast<MaterializeTemporaryExpr>(expr))
expr = matTemp->GetTemporaryExpr();
if (auto bindTemp = dyn_cast<CXXBindTemporaryExpr>(expr))
expr = bindTemp->getSubExpr();
auto temporaryExpr = dyn_cast<CXXTemporaryObjectExpr>(expr);
if (!temporaryExpr)
return true;
if (temporaryExpr->getNumArgs() < 2)
return true;
auto declRefExpr = dyn_cast<DeclRefExpr>(temporaryExpr->getArg(1)->IgnoreImplicit());
if (!declRefExpr)
return true;
auto enumConstant = dyn_cast<EnumConstantDecl>(declRefExpr->getDecl());
if (!enumConstant)
return true;
if (enumConstant->getName() != "UNO_QUERY")
return true;
report(DiagnosticsEngine::Warning,
"calling UNO_QUERY followed by unconditional method call might result in SIGSEGV, "
"rather use UNO_QUERY_THROW",
memberCallExpr->getExprLoc())
<< memberCallExpr->getSourceRange();
return true;
}
loplugin::Plugin::Registration<UnoQuery> unoquery("unoquery", true);
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
