blob: 92660a118722ce1029bd0c6ffe349ae98d73e815 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <stack>
#include "check.hxx"
#include "plugin.hxx"
// In C++, find implicit conversions from char16_t (aka sal_Unicode) to char.
// Such places are probably meant to properly work on char16_t instead.
namespace {
class Visitor final:
public RecursiveASTVisitor<Visitor>, public loplugin::Plugin
{
public:
explicit Visitor(InstantiationData const & data): Plugin(data) {}
bool TraverseCStyleCastExpr(CStyleCastExpr * expr) {
subExprs_.push(expr->getSubExpr());
bool ret = RecursiveASTVisitor::TraverseCStyleCastExpr(expr);
subExprs_.pop();
return ret;
}
bool TraverseCXXStaticCastExpr(CXXStaticCastExpr * expr) {
subExprs_.push(expr->getSubExpr());
bool ret = RecursiveASTVisitor::TraverseCXXStaticCastExpr(expr);
subExprs_.pop();
return ret;
}
bool TraverseCXXFunctionalCastExpr(CXXFunctionalCastExpr * expr) {
subExprs_.push(expr->getSubExpr());
bool ret = RecursiveASTVisitor::TraverseCXXFunctionalCastExpr(expr);
subExprs_.pop();
return ret;
}
bool VisitImplicitCastExpr(ImplicitCastExpr const * expr) {
if ((!subExprs_.empty() && expr == subExprs_.top())
|| ignoreLocation(expr))
{
return true;
}
if (!(loplugin::TypeCheck(expr->getType()).Char()
&& expr->getSubExpr()->getType()->isSpecificBuiltinType(
clang::BuiltinType::Char16)))
{
return true;
}
APSInt res;
if (expr->getSubExpr()->EvaluateAsInt(res, compiler.getASTContext())
&& res >= 0 && res <= 0x7F)
{
return true;
}
report(
DiagnosticsEngine::Warning,
"suspicious implicit cast from %0 to %1",
expr->getExprLoc())
<< expr->getSubExpr()->getType() << expr->getType()
<< expr->getSourceRange();
return true;
}
private:
void run() override {
if (compiler.getLangOpts().CPlusPlus) {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
}
std::stack<Expr const *> subExprs_;
};
static loplugin::Plugin::Registration<Visitor> reg("unicodetochar");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
