blob: b68a8ba327009a286f4bd9557862bf87b034b6d2 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include "check.hxx"
#include "plugin.hxx"
#include <vector>
/** Look for appending result of adding OUString/OString to OUStringBuffer
*/
namespace
{
class StringBuffer : public loplugin::FilteringPlugin<StringBuffer>
{
public:
explicit StringBuffer(loplugin::InstantiationData const& rData)
: FilteringPlugin(rData)
{
}
bool preRun() override
{
StringRef fn(handler.getMainFileName());
return !loplugin::hasPathnamePrefix(fn, SRCDIR "/sal/qa/");
}
void run() override
{
if (preRun())
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
}
bool VisitCXXMemberCallExpr(CXXMemberCallExpr const*);
};
bool StringBuffer::VisitCXXMemberCallExpr(CXXMemberCallExpr const* memberCallExpr)
{
if (ignoreLocation(memberCallExpr))
return true;
if (!loplugin::DeclCheck(memberCallExpr->getRecordDecl())
.Class("OUStringBuffer")
.Namespace("rtl")
.GlobalNamespace())
return true;
if (!memberCallExpr->getMethodDecl()->getIdentifier())
return true;
if (memberCallExpr->getMethodDecl()->getName() != "append")
return true;
auto matTemp = dyn_cast<MaterializeTemporaryExpr>(memberCallExpr->getArg(0));
if (!matTemp)
return true;
if (!isa<CXXOperatorCallExpr>(matTemp->GetTemporaryExpr()))
return true;
report(DiagnosticsEngine::Warning,
"appending added result of OUString to OUStringBuffer, rather do .append(x).append(y)",
compat::getBeginLoc(memberCallExpr))
<< memberCallExpr->getSourceRange();
return true;
}
loplugin::Plugin::Registration<StringBuffer> stringbuffer("stringbuffer", false);
} // namespace
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
