blob: bdf83694b77edb43d33452c385328c3ef7f41596 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include "check.hxx"
#include "plugin.hxx"
namespace {
bool isAsciiCharacterLiteral(Expr const * expr) {
if (auto const e = dyn_cast<CharacterLiteral>(expr)) {
return e->getKind() == CharacterLiteral::Ascii;
}
return false;
}
class SalUnicodeLiteral final:
public loplugin::FilteringPlugin<SalUnicodeLiteral>
{
public:
explicit SalUnicodeLiteral(loplugin::InstantiationData const & data):
FilteringPlugin(data) {}
bool VisitCXXStaticCastExpr(CXXStaticCastExpr const * expr) {
check(expr);
return true;
}
bool VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr const * expr) {
check(expr);
return true;
}
bool VisitCStyleCastExpr(CStyleCastExpr const * expr) {
check(expr);
return true;
}
private:
void run() override {
if (compiler.getLangOpts().CPlusPlus
&& compiler.getPreprocessor().getIdentifierInfo(
"LIBO_INTERNAL_ONLY")->hasMacroDefinition())
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
}
void check(ExplicitCastExpr const * expr) {
if (ignoreLocation(expr)
|| isInUnoIncludeFile(expr->getExprLoc()))
//TODO: '#ifdef LIBO_INTERNAL_ONLY' within UNO include files
{
return;
}
for (auto t = expr->getTypeAsWritten();;) {
auto const tt = t->getAs<TypedefType>();
if (tt == nullptr) {
return;
}
if (loplugin::TypeCheck(t).Typedef("sal_Unicode")
.GlobalNamespace())
{
break;
}
t = tt->desugar();
}
auto const e1 = expr->getSubExprAsWritten();
auto const loc = compat::getBeginLoc(e1);
if (loc.isMacroID()
&& compiler.getSourceManager().isAtStartOfImmediateMacroExpansion(
loc))
{
return;
}
auto const e2 = e1->IgnoreParenImpCasts();
if (isAsciiCharacterLiteral(e2) || isa<IntegerLiteral>(e2)) {
report(
DiagnosticsEngine::Warning,
("in LIBO_INTERNAL_ONLY code, replace literal cast to %0 with a"
" u'...' char16_t character literal"),
e2->getExprLoc())
<< expr->getTypeAsWritten() << expr->getSourceRange();
}
}
};
static loplugin::Plugin::Registration<SalUnicodeLiteral> reg(
"salunicodeliteral");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
