blob: 4f8b0ac34348508ecc3d29bd1be3447b1493fe9d (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <string>
#include <set>
#include "plugin.hxx"
/**
Find code where we are return a const value type from a function.
Which makes no sense.
Either we should return by non-const value, or by const ref.
e.g.
struct S2 {
OUString mv1;
const OUString get13() { return mv1; }
}
Specifically, this code pattern will prevent copy/move optimisations.
*/
namespace
{
class ReturnConstVal : public loplugin::FilteringPlugin<ReturnConstVal>
{
public:
explicit ReturnConstVal(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
bool VisitFunctionDecl(const FunctionDecl* decl);
};
bool ReturnConstVal::VisitFunctionDecl(const FunctionDecl* functionDecl)
{
if (ignoreLocation(functionDecl))
return true;
if (!functionDecl->hasBody())
return true;
// ignore stuff that forms part of the stable URE interface
if (isInUnoIncludeFile(functionDecl))
return true;
QualType t1{ functionDecl->getReturnType() };
if (!t1.isConstQualified())
return true;
if (t1->isReferenceType())
return true;
report(DiagnosticsEngine::Warning, "either return non-const, or by const ref",
functionDecl->getSourceRange().getBegin())
<< functionDecl->getSourceRange();
// display the location of the class member declaration so I don't have to search for it by hand
auto canonicalDecl = functionDecl->getCanonicalDecl();
if (canonicalDecl != functionDecl)
{
report(DiagnosticsEngine::Note, "either return non-const, or by const ref",
canonicalDecl->getSourceRange().getBegin())
<< canonicalDecl->getSourceRange();
}
return true;
}
loplugin::Plugin::Registration<ReturnConstVal> returnconstval("returnconstval");
}
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
