1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include <clang/AST/CXXInheritance.h>
#include "compat.hxx"
#include "plugin.hxx"
/**
* Look for:
* (&x)->y
* which can be transformed to:
* x.y
* And
* &*x
* which can be:
* x
*
* @TODO
* (*x).y
* which can be:
* x->y
*/
namespace {
class RedundantPointerOps:
public RecursiveASTVisitor<RedundantPointerOps>, public loplugin::Plugin
{
public:
explicit RedundantPointerOps(loplugin::InstantiationData const & data): Plugin(data) {}
virtual void run() override
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitFunctionDecl(FunctionDecl const *);
bool VisitMemberExpr(MemberExpr const *);
bool VisitUnaryOperator(UnaryOperator const *);
};
bool RedundantPointerOps::VisitFunctionDecl(FunctionDecl const * functionDecl)
{
if (ignoreLocation(functionDecl))
return true;
//functionDecl->dump();
return true;
}
bool RedundantPointerOps::VisitMemberExpr(MemberExpr const * memberExpr)
{
if (ignoreLocation(memberExpr))
return true;
if (memberExpr->getLocStart().isMacroID())
return true;
auto base = memberExpr->getBase()->IgnoreParenImpCasts();
//parentStmt(parentStmt(memberExpr))->dump();
if (memberExpr->isArrow())
{
if (auto unaryOp = dyn_cast<UnaryOperator>(base))
{
if (unaryOp->getOpcode() == UO_AddrOf)
report(
DiagnosticsEngine::Warning, "'&' followed by '->', rather use '.'",
memberExpr->getLocStart())
<< memberExpr->getSourceRange();
}
else if (auto operatorCallExpr = dyn_cast<CXXOperatorCallExpr>(base))
{
if (operatorCallExpr->getOperator() == OO_Amp)
report(
DiagnosticsEngine::Warning, "'&' followed by '->', rather use '.'",
memberExpr->getLocStart())
<< memberExpr->getSourceRange();
}
}
// else
// {
// if (auto unaryOp = dyn_cast<UnaryOperator>(base))
// {
// if (unaryOp->getOpcode() == UO_Deref)
// report(
// DiagnosticsEngine::Warning, "'*' followed by '.', rather use '->'",
// memberExpr->getLocStart())
// << memberExpr->getSourceRange();
//
// }
// }
return true;
}
bool RedundantPointerOps::VisitUnaryOperator(UnaryOperator const * unaryOperator)
{
if (ignoreLocation(unaryOperator))
return true;
if (unaryOperator->getLocStart().isMacroID())
return true;
if (unaryOperator->getOpcode() != UO_Deref)
return true;
auto innerOp = dyn_cast<UnaryOperator>(unaryOperator->getSubExpr()->IgnoreParenImpCasts());
if (!innerOp || innerOp->getOpcode() != UO_AddrOf)
return true;
report(
DiagnosticsEngine::Warning, "'&' followed by '*', rather use '.'",
unaryOperator->getLocStart())
<< unaryOperator->getSourceRange();
return true;
}
loplugin::Plugin::Registration< RedundantPointerOps > X("redundantpointerops");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
