blob: 41b994c049d5492c48b745026cc348ef069fa1ac (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <string>
#include <iostream>
#include <map>
#include <set>
#include "plugin.hxx"
#include "clang/AST/CXXInheritance.h"
// Check for final classes that have protected members
namespace
{
class FinalProtected:
public loplugin::FilteringPlugin<FinalProtected>
{
public:
explicit FinalProtected(loplugin::InstantiationData const & data):
FilteringPlugin(data) {}
virtual void run() override {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitCXXMethodDecl(CXXMethodDecl const *);
bool VisitFieldDecl(FieldDecl const *);
};
bool FinalProtected::VisitCXXMethodDecl(CXXMethodDecl const * cxxMethodDecl)
{
if (ignoreLocation(cxxMethodDecl)) {
return true;
}
if (cxxMethodDecl->getAccess() != AS_protected) {
return true;
}
if (!cxxMethodDecl->getParent()->hasAttr<FinalAttr>()) {
return true;
}
cxxMethodDecl = cxxMethodDecl->getCanonicalDecl();
report(DiagnosticsEngine::Warning,
"final class should not have protected members - convert them to private",
compat::getBeginLoc(cxxMethodDecl))
<< cxxMethodDecl->getSourceRange();
return true;
}
bool FinalProtected::VisitFieldDecl(FieldDecl const * fieldDecl)
{
if (ignoreLocation(fieldDecl)) {
return true;
}
if (fieldDecl->getAccess() != AS_protected) {
return true;
}
if (!fieldDecl->getParent()->hasAttr<FinalAttr>()) {
return true;
}
fieldDecl = fieldDecl->getCanonicalDecl();
report(DiagnosticsEngine::Warning,
"final class should not have protected members - convert them to private",
compat::getBeginLoc(fieldDecl))
<< fieldDecl->getSourceRange();
return true;
}
loplugin::Plugin::Registration< FinalProtected > finalprotected("finalprotected");
} // namespace
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
