blob: f99077137f9f3392654e0092fa298106f91271e7 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <algorithm>
#include "clang/AST/Attr.h"
#include "clang/AST/CXXInheritance.h"
#include "plugin.hxx"
namespace {
// cf. Clang's clang::AST::CXXDynamicCastExpr::isAlwaysNull
// (lib/AST/ExprCXX.cpp):
bool isAlwaysNull(CXXDynamicCastExpr const * expr) {
QualType SrcType = expr->getSubExpr()->getType();
QualType DestType = expr->getType();
if (const clang::PointerType *SrcPTy = SrcType->getAs<clang::PointerType>()) {
SrcType = SrcPTy->getPointeeType();
#if 0
DestType = DestType->castAs<PointerType>()->getPointeeType();
#else
auto DstPTy = DestType->getAs<clang::PointerType>();
if (!DstPTy)
return false;
DestType = DstPTy->getPointeeType();
#endif
}
if (DestType->isVoidType())
return false;
#if 0
const CXXRecordDecl *SrcRD =
cast<CXXRecordDecl>(SrcType->castAs<RecordType>()->getDecl());
#else
auto SrcRT = SrcType->getAs<RecordType>();
if (!SrcRT)
return false;
const CXXRecordDecl *SrcRD = cast<CXXRecordDecl>(SrcRT->getDecl());
#endif
#if 0
if (!SrcRD->hasAttr<FinalAttr>())
return false;
#endif
#if 0
const CXXRecordDecl *DestRD =
cast<CXXRecordDecl>(DestType->castAs<RecordType>()->getDecl());
#else
auto DestRT = DestType->getAs<RecordType>();
if (!DestRT)
return false;
const CXXRecordDecl *DestRD = cast<CXXRecordDecl>(DestRT->getDecl());
#endif
#if 1
if (!(SrcRD && DestRD))
return false;
if (DestRD->hasAttr<FinalAttr>()) {
CXXBasePaths Paths(/*FindAmbiguities=*/false, /*RecordPaths=*/true,
/*DetectVirtual=*/false);
if (DestRD->isDerivedFrom(SrcRD, Paths) &&
std::all_of(Paths.begin(), Paths.end(),
[](CXXBasePath const & Path) {
return Path.Access != AS_public; }))
return true;
}
if (!SrcRD->hasAttr<FinalAttr>())
return false;
#endif
#if 0
return !DestRD->isDerivedFrom(SrcRD);
#else
return !(DestRD->isDerivedFrom(SrcRD)
|| SrcRD->isDerivedFrom(DestRD)
|| SrcRD == DestRD);
#endif
}
class FailedDynCast:
public RecursiveASTVisitor<FailedDynCast>, public loplugin::Plugin
{
public:
explicit FailedDynCast(loplugin::InstantiationData const & data):
Plugin(data) {}
bool shouldVisitTemplateInstantiations() const { return true; }
void run() override;
bool VisitCXXDynamicCastExpr(CXXDynamicCastExpr const * expr);
};
void FailedDynCast::run() {
if (compiler.getLangOpts().CPlusPlus) {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
}
bool FailedDynCast::VisitCXXDynamicCastExpr(CXXDynamicCastExpr const * expr) {
if (ignoreLocation(expr)) {
return true;
}
if (isAlwaysNull(expr)) {
report(
DiagnosticsEngine::Warning,
"dynamic_cast from %0 to %1 always fails", expr->getLocStart())
<< expr->getSubExpr()->getType() << expr->getType()
<< expr->getSourceRange();
}
return true;
}
loplugin::Plugin::Registration<FailedDynCast> X("faileddyncast");
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
