/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ /* * This file is part of the LibreOffice project. * * This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #include #include #include #include #include #include struct XXX { ~XXX() {} }; class Foo1 { XXX* m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo1() { delete m_pbar; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} m_pbar = nullptr; } }; class Foo2 { char* m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}} char* m_pbar2; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo2() { delete[] m_pbar1; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} delete[] m_pbar2; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } }; class Foo3 { char* m_pbar; bool bMine; ~Foo3() { if (bMine) delete[] m_pbar; } }; class Class4 { int* m_pbar[10]; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Class4() { for (int i = 0; i < 10; ++i) delete m_pbar[i]; // expected-error {{rather manage with std::some_container> [loplugin:useuniqueptr]}} } }; class Class5 { int* m_pbar[10]; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Class5() { for (auto p : m_pbar) // expected-note {{var is here [loplugin:useuniqueptr]}} delete p; // expected-error {{rather manage this with std::some_container> [loplugin:useuniqueptr]}} expected-error {{call to delete on a var, should be using std::unique_ptr [loplugin:useuniqueptr]}} } }; class Class5a { int* m_pbar[10]; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Class5a() { for (auto p : m_pbar) // expected-note {{var is here [loplugin:useuniqueptr]}} { int x = 1; x = x + 2; delete p; // expected-error {{rather manage this with std::some_container> [loplugin:useuniqueptr]}} expected-error {{call to delete on a var, should be using std::unique_ptr [loplugin:useuniqueptr]}} } } }; class Class6 { std::array m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Class6() { for (auto p : m_pbar) // expected-note {{var is here [loplugin:useuniqueptr]}} delete p; // expected-error {{rather manage this with std::some_container> [loplugin:useuniqueptr]}} expected-error {{call to delete on a var, should be using std::unique_ptr [loplugin:useuniqueptr]}} } }; class Class7 { std::array m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Class7() { for (int i = 0; i < 10; ++i) delete m_pbar[i]; // expected-error {{rather manage with std::some_container> [loplugin:useuniqueptr]}} } }; class Class8 { std::unordered_map m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Class8() { for (auto & i : m_pbar) delete i.second; // expected-error {{rather manage this with std::some_container> [loplugin:useuniqueptr]}} } }; class Foo8 { XXX* m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}} XXX* m_pbar2; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo8() { delete m_pbar1; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} delete m_pbar2; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } }; class Foo9 { XXX* m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}} XXX* m_pbar2; // expected-note {{member is here [loplugin:useuniqueptr]}} XXX* m_pbar3; // expected-note {{member is here [loplugin:useuniqueptr]}} XXX* m_pbar4; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo9() { if (m_pbar1) { delete m_pbar1; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } if (m_pbar2 != nullptr) { delete m_pbar2; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } if (m_pbar3 != nullptr) delete m_pbar3; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} if (m_pbar4 != nullptr) { int x = 1; (void)x; delete m_pbar4; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } } }; // no warning expected class Foo10 { XXX* m_pbar1; ~Foo10() { if (m_pbar1 != getOther()) { delete m_pbar1; } } XXX* getOther() { return nullptr; } }; class Foo11 { std::vector m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo11() { for (const auto & p : m_pbar1) // expected-note {{var is here [loplugin:useuniqueptr]}} { delete p; // expected-error {{rather manage this with std::some_container> [loplugin:useuniqueptr]}} expected-error {{call to delete on a var, should be using std::unique_ptr [loplugin:useuniqueptr]}} } } }; class Foo12 { std::array m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo12() { int i = 0; while (i < 10) delete m_pbar[i++]; // expected-error {{rather manage with std::some_container> [loplugin:useuniqueptr]}} } }; #define DELETEZ( p ) ( delete p,p = NULL ) class Foo13 { int * m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}} int * m_pbar2; // expected-note {{member is here [loplugin:useuniqueptr]}} int * m_pbar3; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo13() { if (m_pbar1) DELETEZ(m_pbar1); // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} DELETEZ(m_pbar2); // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} if (m_pbar3) { DELETEZ(m_pbar3); // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } } }; // check for unconditional inner compound statements class Foo14 { int * m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo14() { { delete m_pbar1; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } } }; void Foo15(int * p) { delete p; // expected-error {{calling delete on a pointer param, should be either whitelisted or simplified [loplugin:useuniqueptr]}} }; class Foo16 { Foo16(int * p) { delete p; // expected-error {{calling delete on a pointer param, should be either whitelisted or simplified [loplugin:useuniqueptr]}} }; void foo(int * p) { delete p; // expected-error {{calling delete on a pointer param, should be either whitelisted or simplified [loplugin:useuniqueptr]}} }; }; // check for delete on array members class Foo17 { int * m_pbar1[6]; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo17() { delete m_pbar1[0]; // expected-error {{unconditional call to delete on an array member, should be using std::unique_ptr [loplugin:useuniqueptr]}} } }; // this only starts to work somewhere after clang 3.8 and before clang7 #if CLANG_VERSION >= 30900 class Foo18 { std::vector m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo18() { for (auto aIter = m_pbar1.begin(); aIter != m_pbar1.end(); ++aIter) delete *aIter; // expected-error {{rather manage with std::some_container> [loplugin:useuniqueptr]}} } }; #endif void foo19() { std::vector vec; // expected-note {{var is here [loplugin:useuniqueptr]}} for(char * p : vec) delete p; // expected-error {{rather manage this var with std::some_container> [loplugin:useuniqueptr]}} } // no warning expected namespace foo20 { struct struct20_1 {}; struct struct20_2 : public struct20_1 { char * p; }; void foo20(struct20_1 * pMapping) { delete static_cast< struct20_2 * >( pMapping )->p; } }; // ------------------------------------------------------------------------------------------------ // tests for deleting when looping via iterators // ------------------------------------------------------------------------------------------------ void foo21() { std::vector vec; // expected-note {{var is here [loplugin:useuniqueptr]}} for(auto it = vec.begin(); it != vec.end(); ++it) delete *it; // expected-error {{rather manage this var with std::some_container> [loplugin:useuniqueptr]}} } void foo22() { std::unordered_map map; // expected-note {{var is here [loplugin:useuniqueptr]}} for(auto it = map.begin(); it != map.end(); ++it) delete it->second; // expected-error {{rather manage this var with std::some_container> [loplugin:useuniqueptr]}} } class Foo23 { std::unordered_map map; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo23() { for(auto it = map.begin(); it != map.end(); ++it) delete it->second; // expected-error {{rather manage with std::some_container> [loplugin:useuniqueptr]}} } }; class Foo24 { typedef std::vector HTMLAttrs; HTMLAttrs m_aSetAttrTab; // expected-note {{member is here [loplugin:useuniqueptr]}} ~Foo24() { for ( HTMLAttrs::const_iterator it = m_aSetAttrTab.begin(); it != m_aSetAttrTab.end(); ++it ) delete *it; // expected-error {{rather manage with std::some_container> [loplugin:useuniqueptr]}} } }; // ------------------------------------------------------------------------------------------------ // tests for passing owning pointers to constructors // ------------------------------------------------------------------------------------------------ class Bravo1 { std::unique_ptr m_field1; Bravo1(int* p) : m_field1(p) // expected-error {{should be passing via std::unique_ptr param [loplugin:useuniqueptr]}} {} }; class Bravo2 { std::unique_ptr m_field1; Bravo2(std::unique_ptr p) : m_field1(std::move(p)) // no warning expected {} }; /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */