From dd2681813d02089c71a8b0f4dc4c8e2bf63d1791 Mon Sep 17 00:00:00 2001 From: Justin Luth Date: Fri, 10 Apr 2020 20:02:20 +0300 Subject: NFC writerfilter: remove pointless asserts In an age where GDB (or whatever other platform debugger you prefer) is easy to use, there is no point in asserting something that is going to crash anyway, is there? Asserting is only good in these cases if you follow it using an _if_ statement. Noel informed me that it can also be used to silence false positive coverity warnings. Change-Id: I5a5cb7a22019768ec2807f6918d4a8ebb51194de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92049 Tested-by: Jenkins Reviewed-by: Noel Grandin --- writerfilter/source/rtftok/rtfdocumentimpl.cxx | 1 - 1 file changed, 1 deletion(-) (limited to 'writerfilter/source/rtftok/rtfdocumentimpl.cxx') diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index 3de574e75c12..5429489304f6 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -2113,7 +2113,6 @@ RTFReferenceTable::Entries_t RTFDocumentImpl::deduplicateStyleTable() auto const pStyleType( static_cast(*pStyle).getAttributes().find( NS_ooxml::LN_CT_Style_type)); - assert(pStyleType); int const nStyleType(pStyleType->getInt()); RTFSprms const sprms( static_cast(*pStyle).getSprms().cloneAndDeduplicate( -- cgit v1.2.1