From b09deb075319c1c19f91e3a6f64429b61682ebf8 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 28 Jul 2017 11:47:51 +0200 Subject: loplugin:constparams handle constructors had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins Reviewed-by: Noel Grandin --- vcl/source/filter/FilterConfigItem.cxx | 4 ++-- vcl/source/filter/graphicfilter.cxx | 2 +- vcl/source/filter/ipdf/pdfdocument.cxx | 2 +- vcl/source/filter/jpeg/JpegWriter.cxx | 2 +- vcl/source/outdev/bitmap.cxx | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) (limited to 'vcl/source') diff --git a/vcl/source/filter/FilterConfigItem.cxx b/vcl/source/filter/FilterConfigItem.cxx index 2047ff882215..b0458df5430f 100644 --- a/vcl/source/filter/FilterConfigItem.cxx +++ b/vcl/source/filter/FilterConfigItem.cxx @@ -144,7 +144,7 @@ FilterConfigItem::FilterConfigItem( const OUString& rSubTree ) ImpInitTree( rSubTree ); } -FilterConfigItem::FilterConfigItem( css::uno::Sequence< css::beans::PropertyValue >* pFilterData ) +FilterConfigItem::FilterConfigItem( css::uno::Sequence< css::beans::PropertyValue > const * pFilterData ) : bModified(false) { if ( pFilterData ) @@ -152,7 +152,7 @@ FilterConfigItem::FilterConfigItem( css::uno::Sequence< css::beans::PropertyValu } FilterConfigItem::FilterConfigItem( const OUString& rSubTree, - css::uno::Sequence< css::beans::PropertyValue >* pFilterData ) + css::uno::Sequence< css::beans::PropertyValue > const * pFilterData ) { ImpInitTree( rSubTree ); diff --git a/vcl/source/filter/graphicfilter.cxx b/vcl/source/filter/graphicfilter.cxx index b99d5e0c8490..23070eb10622 100644 --- a/vcl/source/filter/graphicfilter.cxx +++ b/vcl/source/filter/graphicfilter.cxx @@ -2030,7 +2030,7 @@ ErrCode GraphicFilter::ExportGraphic( const Graphic& rGraphic, const OUString& r if( nFormat >= nFormatCount ) return ImplSetError( ERRCODE_GRFILTER_FORMATERROR ); - FilterConfigItem aConfigItem( const_cast*>(pFilterData) ); + FilterConfigItem aConfigItem( pFilterData ); OUString aFilterName( pConfig->GetExportFilterName( nFormat ) ); #ifndef DISABLE_DYNLOADING OUString aExternalFilterName(pConfig->GetExternalFilterName(nFormat, true)); diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx b/vcl/source/filter/ipdf/pdfdocument.cxx index f6a8de05363c..a7ad2c73c897 100644 --- a/vcl/source/filter/ipdf/pdfdocument.cxx +++ b/vcl/source/filter/ipdf/pdfdocument.cxx @@ -2727,7 +2727,7 @@ PDFDocument& PDFObjectElement::GetDocument() return m_rDoc; } -PDFReferenceElement::PDFReferenceElement(PDFDocument& rDoc, PDFNumberElement& rObject, PDFNumberElement& rGeneration) +PDFReferenceElement::PDFReferenceElement(PDFDocument& rDoc, PDFNumberElement& rObject, PDFNumberElement const & rGeneration) : m_rDoc(rDoc), m_fObjectValue(rObject.GetValue()), m_fGenerationValue(rGeneration.GetValue()), diff --git a/vcl/source/filter/jpeg/JpegWriter.cxx b/vcl/source/filter/jpeg/JpegWriter.cxx index eff1bacd2ddb..1cf302312b22 100644 --- a/vcl/source/filter/jpeg/JpegWriter.cxx +++ b/vcl/source/filter/jpeg/JpegWriter.cxx @@ -109,7 +109,7 @@ JPEGWriter::JPEGWriter( SvStream& rStream, const css::uno::Sequence< css::beans: mbNative ( false ), mpExpWasGrey ( pExportWasGrey ) { - FilterConfigItem aConfigItem( const_cast*>(pFilterData) ); + FilterConfigItem aConfigItem( pFilterData ); mbGreys = aConfigItem.ReadInt32( "ColorMode", 0 ) != 0; mnQuality = aConfigItem.ReadInt32( "Quality", 75 ); maChromaSubsampling = aConfigItem.ReadInt32( "ChromaSubsamplingMode", 0 ); diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx index 071435544097..40ad7f23034d 100644 --- a/vcl/source/outdev/bitmap.cxx +++ b/vcl/source/outdev/bitmap.cxx @@ -718,7 +718,7 @@ struct LinearScaleContext std::unique_ptr mpMapXOffset; std::unique_ptr mpMapYOffset; - LinearScaleContext(tools::Rectangle& aDstRect, tools::Rectangle& aBitmapRect, + LinearScaleContext(tools::Rectangle const & aDstRect, tools::Rectangle& aBitmapRect, Size& aOutSize, long nOffX, long nOffY) : mpMapX(new long[aDstRect.GetWidth()]) @@ -882,7 +882,7 @@ struct TradScaleContext std::unique_ptr mpMapX; std::unique_ptr mpMapY; - TradScaleContext(tools::Rectangle& aDstRect, tools::Rectangle& aBitmapRect, + TradScaleContext(tools::Rectangle const & aDstRect, tools::Rectangle& aBitmapRect, Size& aOutSize, long nOffX, long nOffY) : mpMapX(new long[aDstRect.GetWidth()]) -- cgit v1.2.3