From d8910519f1bc5aa284a79b7d24581d087adf0c29 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Sat, 11 Sep 2021 14:11:38 +0200 Subject: clang:optin.performance.Padding Excessive padding in 'struct ValueSetItem' (8 padding bytes, where 0 is optimal). Excessive padding in 'struct framework::CommandInfo' (12 padding bytes, where 4 is optimal). Optimal fields order: aIds, nId, nImageInfo, consider reordering the fields or adding explicit padding members [optin.performance.Padding] Excessive padding in 'class drawinglayer::attribute::ImpFillGradientAttribute' (10 padding bytes, where 2 is optimal). Excessive padding in 'class drawinglayer::attribute::ImpSdrLineAttribute' (8 padding bytes, where 0 is optimal). Change-Id: I606f2bfc2c0c51b386182b900401dd15b5404451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121938 Tested-by: Jenkins Reviewed-by: Noel Grandin --- svtools/source/control/valueacc.cxx | 4 ++-- svtools/source/control/valueimp.hxx | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) (limited to 'svtools') diff --git a/svtools/source/control/valueacc.cxx b/svtools/source/control/valueacc.cxx index 7c12373f5982..2f47f2616ae0 100644 --- a/svtools/source/control/valueacc.cxx +++ b/svtools/source/control/valueacc.cxx @@ -36,11 +36,11 @@ using namespace ::com::sun::star; ValueSetItem::ValueSetItem( ValueSet& rParent ) : mrParent(rParent) + , mpData(nullptr) + , mxAcc() , mnId(0) , meType(VALUESETITEM_NONE) , mbVisible(true) - , mpData(nullptr) - , mxAcc() { } diff --git a/svtools/source/control/valueimp.hxx b/svtools/source/control/valueimp.hxx index 707493443b75..ca25ddbc12cf 100644 --- a/svtools/source/control/valueimp.hxx +++ b/svtools/source/control/valueimp.hxx @@ -52,14 +52,14 @@ class ValueSet; struct ValueSetItem { ValueSet& mrParent; - sal_uInt16 mnId; - sal_uInt8 meType; - bool mbVisible; - Image maImage; - Color maColor; OUString maText; void* mpData; rtl::Reference< ValueItemAcc > mxAcc; + Image maImage; + Color maColor; + sal_uInt16 mnId; + sal_uInt8 meType; + bool mbVisible; explicit ValueSetItem( ValueSet& rParent ); ~ValueSetItem(); -- cgit v1.2.3