From bb6f5ae90332fee2eb650398d1ae0b554ac89ce2 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 24 Jul 2019 10:57:27 +0100 Subject: cid#1448446 Unchecked dynamic_cast MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I790f55e5edfce37b28dfc8b915970e123425f434 Reviewed-on: https://gerrit.libreoffice.org/76244 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- sdext/source/pdfimport/tree/writertreevisiting.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'sdext') diff --git a/sdext/source/pdfimport/tree/writertreevisiting.cxx b/sdext/source/pdfimport/tree/writertreevisiting.cxx index b84e5f2fcb07..96b9e4bcfab9 100644 --- a/sdext/source/pdfimport/tree/writertreevisiting.cxx +++ b/sdext/source/pdfimport/tree/writertreevisiting.cxx @@ -671,8 +671,8 @@ void WriterXmlOptimizer::checkHeaderAndFooter( PageElement& rElem ) auto it = std::find_if(rElem.Children.begin(), rElem.Children.end(), isParagraphElement); if (it != rElem.Children.end()) { - ParagraphElement* pPara = dynamic_cast(it->get()); - if( pPara->y+pPara->h < rElem.h*0.15 && pPara->isSingleLined( m_rProcessor ) ) + ParagraphElement& rPara = dynamic_cast(*it->get()); + if( rPara.y+rPara.h < rElem.h*0.15 && rPara.isSingleLined( m_rProcessor ) ) { auto next_it = it; ParagraphElement* pNextPara = nullptr; @@ -680,10 +680,10 @@ void WriterXmlOptimizer::checkHeaderAndFooter( PageElement& rElem ) { pNextPara = dynamic_cast(next_it->get()); } - if( pNextPara && pNextPara->y > pPara->y+pPara->h*2 ) + if( pNextPara && pNextPara->y > rPara.y+rPara.h*2 ) { rElem.HeaderElement = std::move(*it); - pPara->Parent = nullptr; + rPara.Parent = nullptr; rElem.Children.erase( it ); } } -- cgit v1.2.3