From 416596954529dd7897ab81951c47ba5984b11a34 Mon Sep 17 00:00:00 2001 From: Zolnai Tamás Date: Tue, 23 Dec 2014 10:45:19 +0100 Subject: bnc#822341: PPTX export of embedded text documents -Make embedded text documents exported by analogy with spreadsheet embedded documents. -Convert MS ole objects to LO sepcific objecst to allow exporting those ole objects too. Plus use gb_CppunitTest_use_rdb instead of wasting time on finding out which missing components cause test failing. Especcially when we have platform dependent components (e.g. related to embedded object) (cherry picked from commit 0c3d5fb0ad35ff7fc18917fc86fa58d9312fe3ae) Conflicts: sd/qa/unit/export-tests.cxx ERROR: Attribute 'spid' must appear on element 'p:oleObj'. As pointed out by CppunitTest_sd_export_tests. (cherry picked from commit 124c33dd1d6bf2040f0153de8c9ecaebe759c3bd) ERROR: Invalid content was found starting with element 'p:pic'. Again, as pointed out by CppunitTest_sd_export_tests. Sadly it seems that the spec and PowerPoint is not in sync here, so just do what makes both happy. This fixes the --with-export-validation build. (cherry picked from commit cf15306ccf49da290b391517e2c5dd22a4f1be45) Change-Id: Ic76d659b51274777a1669c215344a1169ebcba81 8ecbc3ef4ea9dc84ebf88506967d02de04ded852 c76d659b51274777a1669c215344a1169ebcba81 Reviewed-on: https://gerrit.libreoffice.org/13600 Reviewed-by: Andras Timar Tested-by: Andras Timar --- sd/CppunitTest_sd_export_tests.mk | 41 +--------------------------------- sd/qa/unit/data/odp/bnc822341.odp | Bin 0 -> 15983 bytes sd/qa/unit/export-tests.cxx | 45 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 46 insertions(+), 40 deletions(-) create mode 100644 sd/qa/unit/data/odp/bnc822341.odp (limited to 'sd') diff --git a/sd/CppunitTest_sd_export_tests.mk b/sd/CppunitTest_sd_export_tests.mk index a8f3dbfa067b..1c54b95f0c99 100644 --- a/sd/CppunitTest_sd_export_tests.mk +++ b/sd/CppunitTest_sd_export_tests.mk @@ -65,46 +65,7 @@ $(eval $(call gb_CppunitTest_use_api,sd_export_tests,\ $(eval $(call gb_CppunitTest_use_ure,sd_export_tests)) $(eval $(call gb_CppunitTest_use_vcl,sd_export_tests)) -$(eval $(call gb_CppunitTest_use_components,sd_export_tests,\ - animations/source/animcore/animcore \ - basic/util/sb \ - chart2/source/chartcore \ - chart2/source/controller/chartcontroller \ - comphelper/util/comphelp \ - configmgr/source/configmgr \ - dbaccess/util/dba \ - desktop/source/deployment/deployment \ - embeddedobj/util/embobj \ - filter/source/config/cache/filterconfig1 \ - filter/source/svg/svgfilter \ - forms/util/frm \ - framework/util/fwk \ - i18npool/util/i18npool \ - linguistic/source/lng \ - oox/util/oox \ - package/source/xstor/xstor \ - package/util/package2 \ - sax/source/expatwrap/expwrap \ - sd/util/sd \ - sd/util/sdfilt \ - sd/util/sdd \ - sfx2/util/sfx \ - sot/util/sot \ - svl/source/fsstor/fsstorage \ - svtools/util/svt \ - toolkit/util/tk \ - ucb/source/core/ucb1 \ - ucb/source/ucp/expand/ucpexpand1 \ - ucb/source/ucp/file/ucpfile1 \ - ucb/source/ucp/package/ucppkg1 \ - ucb/source/ucp/tdoc/ucptdoc1 \ - unotools/util/utl \ - unoxml/source/rdf/unordf \ - unoxml/source/service/unoxml \ - xmloff/util/xo \ - xmlsecurity/util/xsec_fw \ - xmlsecurity/util/xmlsecurity \ -)) +$(eval $(call gb_CppunitTest_use_rdb,sd_export_tests,services)) $(eval $(call gb_CppunitTest_use_custom_headers,sd_export_tests,\ officecfg/registry \ diff --git a/sd/qa/unit/data/odp/bnc822341.odp b/sd/qa/unit/data/odp/bnc822341.odp new file mode 100644 index 000000000000..28fe2f4f4b8b Binary files /dev/null and b/sd/qa/unit/data/odp/bnc822341.odp differ diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx index 7b176681ee83..66b386705fa0 100644 --- a/sd/qa/unit/export-tests.cxx +++ b/sd/qa/unit/export-tests.cxx @@ -80,6 +80,9 @@ public: void testFdo79731(); void testSwappedOutImageExport(); void testLinkedGraphicRT(); +#if !defined WNT + void testBnc822341(); +#endif CPPUNIT_TEST_SUITE(SdExportTest); CPPUNIT_TEST(testN821567); @@ -98,6 +101,9 @@ public: CPPUNIT_TEST(testFdo79731); CPPUNIT_TEST(testSwappedOutImageExport); CPPUNIT_TEST(testLinkedGraphicRT); +#if !defined WNT + CPPUNIT_TEST(testBnc822341); +#endif CPPUNIT_TEST_SUITE_END(); }; @@ -638,6 +644,45 @@ void SdExportTest::testLinkedGraphicRT() } } +#if !defined WNT + +void SdExportTest::testBnc822341() +{ + // Check import / export of embedded text document + ::sd::DrawDocShellRef xDocShRef = loadURL(getURLFromSrc("sd/qa/unit/data/odp/bnc822341.odp"), ODP); + xDocShRef = saveAndReload( xDocShRef, PPTX ); + + // Export an LO specific ole object (imported from an ODP document) + { + SdDrawDocument *pDoc = xDocShRef->GetDoc(); + CPPUNIT_ASSERT_MESSAGE( "no document", pDoc != NULL ); + const SdrPage *pPage = pDoc->GetPage(1); + CPPUNIT_ASSERT_MESSAGE( "no page", pPage != NULL ); + + const SdrObject* pObj = dynamic_cast( pPage->GetObj(0) ); + CPPUNIT_ASSERT_MESSAGE( "no object", pObj != NULL); + CPPUNIT_ASSERT_EQUAL( static_cast(OBJ_OLE2), pObj->GetObjIdentifier() ); + } + + xDocShRef = saveAndReload( xDocShRef, PPTX ); + + // Export an MS specific ole object (imported from a PPTX document) + { + SdDrawDocument *pDoc = xDocShRef->GetDoc(); + CPPUNIT_ASSERT_MESSAGE( "no document", pDoc != NULL ); + const SdrPage *pPage = pDoc->GetPage(1); + CPPUNIT_ASSERT_MESSAGE( "no page", pPage != NULL ); + + const SdrObject* pObj = dynamic_cast( pPage->GetObj(0) ); + CPPUNIT_ASSERT_MESSAGE( "no object", pObj != NULL); + CPPUNIT_ASSERT_EQUAL( static_cast(OBJ_OLE2), pObj->GetObjIdentifier() ); + } + + xDocShRef->DoClose(); +} + +#endif + CPPUNIT_TEST_SUITE_REGISTRATION(SdExportTest); CPPUNIT_PLUGIN_IMPLEMENT(); -- cgit v1.2.3