From 4225092a3586498f27dcb3cc54ae7f5b8ea53d4e Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Fri, 4 Mar 2016 15:51:04 +0100 Subject: cid#1326861,1326862: Eq: Problems with implementation of equals() Cloneable, odd additional equals overloads, odd hasCode implementation---all smells like clueless cargo cult. And I see no place where it would get used. Change-Id: Icca89531ce9181fb47eacfb6fae704f4f45012a9 --- .../star/script/framework/container/ScriptEntry.java | 19 +------------------ .../script/framework/container/ScriptMetaData.java | 9 --------- 2 files changed, 1 insertion(+), 27 deletions(-) (limited to 'scripting') diff --git a/scripting/java/com/sun/star/script/framework/container/ScriptEntry.java b/scripting/java/com/sun/star/script/framework/container/ScriptEntry.java index eb4eb44beb0c..92870c68006e 100644 --- a/scripting/java/com/sun/star/script/framework/container/ScriptEntry.java +++ b/scripting/java/com/sun/star/script/framework/container/ScriptEntry.java @@ -21,7 +21,7 @@ package com.sun.star.script.framework.container; import java.util.HashMap; import java.util.Map; -public class ScriptEntry implements Cloneable { +public class ScriptEntry { private final String language; private final String languagename; @@ -56,23 +56,6 @@ public class ScriptEntry implements Cloneable { this.description = description; } - @Override - public Object clone() throws CloneNotSupportedException { - return super.clone(); - } - - public boolean equals(ScriptEntry other) { - return language.equals(other.getLanguage()) && - languagename.equals(other.getLanguageName()) && - logicalname.equals(other.getLogicalName()) && - languagedepprops.equals(other.getLanguageProperties()); - } - - @Override - public int hashCode() { - return 0; - } - public Map getLanguageProperties() { return languagedepprops; } diff --git a/scripting/java/com/sun/star/script/framework/container/ScriptMetaData.java b/scripting/java/com/sun/star/script/framework/container/ScriptMetaData.java index 75f075289cc5..004fe2b181e9 100644 --- a/scripting/java/com/sun/star/script/framework/container/ScriptMetaData.java +++ b/scripting/java/com/sun/star/script/framework/container/ScriptMetaData.java @@ -66,15 +66,6 @@ public class ScriptMetaData extends ScriptEntry { return (source != null && hasSource) ? source.getBytes() : null; } - public boolean equals(ScriptMetaData other) { - return super.equals(other) && hasSource == other.hasSource(); - } - - @Override - public int hashCode() { - return 0; - } - public String getScriptFullURL() { String url = "vnd.sun.star.script:" + parent.getName() + "." + getLanguageName() + "?" + "language=" + getLanguage() -- cgit v1.2.3