From 6a789e617ed07bfddc516c8fc0cf94cd6dfe7250 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Sat, 5 Oct 2019 13:32:10 +0200 Subject: improve SfxPoolItem operator== implementations (*) make them all call the superclass operator== (*) make the base class check which and typeid to ensure we are only comparing the safe subclasses together (*) remove a couple of operator== that were not doing anything useful Change-Id: Ia6234aed42df04157a5d6a323dc951916a9cb316 Reviewed-on: https://gerrit.libreoffice.org/80308 Tested-by: Jenkins Reviewed-by: Noel Grandin --- sc/source/ui/condformat/condformatdlgitem.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sc/source/ui/condformat/condformatdlgitem.cxx') diff --git a/sc/source/ui/condformat/condformatdlgitem.cxx b/sc/source/ui/condformat/condformatdlgitem.cxx index ee37c734d94d..ee1713b06f04 100644 --- a/sc/source/ui/condformat/condformatdlgitem.cxx +++ b/sc/source/ui/condformat/condformatdlgitem.cxx @@ -27,8 +27,9 @@ ScCondFormatDlgItem::~ScCondFormatDlgItem() { } -bool ScCondFormatDlgItem::operator==(const SfxPoolItem& /*rItem*/) const +bool ScCondFormatDlgItem::operator==(const SfxPoolItem& rItem) const { + assert(SfxPoolItem::operator==(rItem)); (void)rItem; return false; } -- cgit v1.2.3