From 84dc0157df9cb173ec74da2bd27507329efc3816 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Thu, 23 Jun 2016 14:40:15 +0100 Subject: Related: tdf#100460 GetNotesInRange doesn't count last cell in range e.g. open document from tdf#100460 and select select A20:A21 and right click and there is a hide comment entry. Shrink the selection to just A20 (which has the comment in it) and the right click menu has no hide comment entry in it. std::for_each(it, itEnd means it < itEnd but here we want the rows indicated by nStartRow <= nEndRow so we need to increment itEnd by one to get the right range Change-Id: I48e8c0748f520671e09f04b16961bf9729960317 --- sc/qa/unit/ucalc.cxx | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'sc/qa/unit/ucalc.cxx') diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 9cecaccf510c..5a38c92fabfc 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -4980,6 +4980,12 @@ void Test::testNoteCopyPaste() CPPUNIT_ASSERT(pNote); CPPUNIT_ASSERT_EQUAL(OUString("Note2"), pNote->GetText()); + // Test that GetNotesInRange includes the end of its range + // and so can find the note + std::vector aNotes; + m_pDoc->GetNotesInRange(ScRange(1,7,0), aNotes); + CPPUNIT_ASSERT_EQUAL(size_t(1), aNotes.size()); + m_pDoc->DeleteTab(0); } -- cgit v1.2.3