From d5129a9dd68978f9eccdd4597b5b6834557c422a Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 27 May 2015 16:33:44 +0200 Subject: new clang plugin: loopvartoosmall Idea from bubli - look for loops where the index variable is of such size that it cannot cover the range revealed by examining the length part of the condition. So far, I have only run the plugin up till the VCL module. Also the plugin deliberately excludes anything more complicated than a straightforward incrementing for loop. Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015 --- registry/source/regimpl.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'registry/source') diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx index 6af272039128..e20b41d13794 100644 --- a/registry/source/regimpl.cxx +++ b/registry/source/regimpl.cxx @@ -1274,7 +1274,7 @@ RegError ORegistry::mergeModuleValue(OStoreStream& rTargetValue, 0, 0); - for (sal_uInt16 i=0 ; i < reader.getFieldCount(); i++) + for (sal_uInt32 i=0 ; i < reader.getFieldCount(); i++) { writer.setFieldData(index, reader.getFieldName(i), @@ -1285,7 +1285,7 @@ RegError ORegistry::mergeModuleValue(OStoreStream& rTargetValue, reader.getFieldConstValue(i)); index++; } - for (sal_uInt16 i=0 ; i < reader2.getFieldCount(); i++) + for (sal_uInt32 i=0 ; i < reader2.getFieldCount(); i++) { if (nameSet.find(reader2.getFieldName(i)) == nameSet.end()) { -- cgit v1.2.3