From b51d44462f52188f4e1574168ec759c8008a40b7 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Fri, 5 Dec 2014 12:42:34 +0100 Subject: Broken cast All the way back since 2001 (ed53aaf5842e82f9a8d4d053b39e7db61c6d62ce "#89611# react for (Beamer!)Frame->dispose() from outside," adding member SfxChildWindow_Impl::xListener), that MyStruct hack was not in sync with SfxChildWindow_Impl, so ((MyStruct*)pImp)->bVisible = false; probably corrputed pFact rather than change bVisible. The origin of that MyStruct hack is lost to history, but probably stems from an ancient time when changes across modules where prohibitively expensive, esp. when some feature had to be crammed in shortly before release... Change-Id: I13dc30c96ef70b2cc09dc117231c021910e0ce1e (cherry picked from commit 0cb6a92f86e02f6342be5e8f931dc1849114230c) --- include/sfx2/childwin.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include') diff --git a/include/sfx2/childwin.hxx b/include/sfx2/childwin.hxx index 4fe4c008ee6a..c1b88906fe81 100644 --- a/include/sfx2/childwin.hxx +++ b/include/sfx2/childwin.hxx @@ -217,7 +217,7 @@ public: void SetFrame( const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XFrame > & ); SAL_DLLPRIVATE static void InitializeChildWinFactory_Impl(sal_uInt16, SfxChildWinInfo&); - SAL_DLLPRIVATE void SetVisible_Impl( bool bVis ); + void SetVisible_Impl( bool bVis ); SAL_DLLPRIVATE void SetWorkWindow_Impl( SfxWorkWindow* ); SAL_DLLPRIVATE void Activate_Impl(); SAL_DLLPRIVATE void Deactivate_Impl(); -- cgit v1.2.3