From 30a75a8d3dcfcca2cf349d9df797ac0b1550eb5e Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Tue, 30 Jul 2019 11:48:19 +0300 Subject: tdf#125568: We need the selection string also when not "in selection mode" Apparently being "in selection mode" has nothing to do with whether we have a selection that we are enlarging by dragging the end marker? Change-Id: I546a1685bd3a0102e16c1f8bc6e721819ed986e2 Reviewed-on: https://gerrit.libreoffice.org/76588 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna Reviewed-on: https://gerrit.libreoffice.org/76591 Tested-by: Jenkins Reviewed-by: Tor Lillqvist Tested-by: Tor Lillqvist --- editeng/source/editeng/impedit.cxx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'editeng') diff --git a/editeng/source/editeng/impedit.cxx b/editeng/source/editeng/impedit.cxx index a30d658ba492..5b7de9ae81e3 100644 --- a/editeng/source/editeng/impedit.cxx +++ b/editeng/source/editeng/impedit.cxx @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -411,7 +412,10 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel, vcl::Region* pRegion, OString sRectangle; // If we are not in selection mode, then the exported own selection should be empty. - if (pEditEngine->pImpEditEngine->IsInSelectionMode() || mpOtherShell) + // This is needed always in Online, regardless whether in "selection mode" (whatever + // that is) or not, for tdf#125568, but I don't have the clout to make this completely + // unconditional also for desktop LO. + if (comphelper::LibreOfficeKit::isActive() || pEditEngine->pImpEditEngine->IsInSelectionMode() || mpOtherShell) { std::vector aRectangles; pRegion->GetRegionRectangles(aRectangles); -- cgit v1.2.3