From 64385c7555c6bbb089f3ab8b2a5b623cadd6ee7d Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Sun, 5 Jul 2015 21:05:13 +0100 Subject: cppcheck: noExplicitConstructor Change-Id: I999923031c573f361bc421eab84e68a4a130d688 --- dbaccess/source/core/dataaccess/SharedConnection.hxx | 2 +- dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx | 4 ++-- dbaccess/source/core/dataaccess/databasecontext.cxx | 2 +- dbaccess/source/core/dataaccess/databasecontext.hxx | 2 +- dbaccess/source/core/dataaccess/databasedocument.hxx | 4 ++-- dbaccess/source/core/dataaccess/databaseregistrations.cxx | 2 +- dbaccess/source/core/dataaccess/datasource.cxx | 4 ++-- dbaccess/source/core/dataaccess/datasource.hxx | 2 +- dbaccess/source/core/dataaccess/definitioncontainer.cxx | 2 +- dbaccess/source/core/dataaccess/documentcontainer.cxx | 2 +- dbaccess/source/core/dataaccess/documentdefinition.cxx | 10 +++++----- dbaccess/source/core/dataaccess/documenteventexecutor.cxx | 2 +- dbaccess/source/core/dataaccess/intercept.hxx | 2 +- dbaccess/source/core/dataaccess/myucp_datasupplier.cxx | 2 +- dbaccess/source/core/recovery/dbdocrecovery.cxx | 2 +- dbaccess/source/core/recovery/settingsimport.hxx | 6 +++--- dbaccess/source/core/recovery/subcomponentloader.cxx | 4 ++-- dbaccess/source/ext/macromigration/docinteraction.cxx | 2 +- dbaccess/source/ext/macromigration/macromigrationpages.hxx | 8 ++++---- 19 files changed, 32 insertions(+), 32 deletions(-) (limited to 'dbaccess') diff --git a/dbaccess/source/core/dataaccess/SharedConnection.hxx b/dbaccess/source/core/dataaccess/SharedConnection.hxx index 28c419c95185..afc5603f8674 100644 --- a/dbaccess/source/core/dataaccess/SharedConnection.hxx +++ b/dbaccess/source/core/dataaccess/SharedConnection.hxx @@ -52,7 +52,7 @@ namespace dbaccess virtual void SAL_CALL disposing() SAL_OVERRIDE; virtual ~OSharedConnection(); public: - OSharedConnection(::com::sun::star::uno::Reference< ::com::sun::star::uno::XAggregation >& _rxProxyConnection); + explicit OSharedConnection(::com::sun::star::uno::Reference< ::com::sun::star::uno::XAggregation >& _rxProxyConnection); virtual ::com::sun::star::uno::Sequence< sal_Int8 > SAL_CALL getImplementationId( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx b/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx index c3072d65351b..ae63130a138b 100644 --- a/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx +++ b/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx @@ -78,7 +78,7 @@ namespace dbaccess ,public ::comphelper::OPropertyArrayUsageHelper< DataAccessDescriptor > { public: - DataAccessDescriptor( const Reference & _rContext ); + explicit DataAccessDescriptor( const Reference & _rContext ); // UNO DECLARE_XINTERFACE() @@ -234,7 +234,7 @@ namespace dbaccess virtual Reference< XPropertySet > SAL_CALL createDataAccessDescriptor( ) throw (RuntimeException, std::exception) SAL_OVERRIDE; protected: - DataAccessDescriptorFactory( const Reference< XComponentContext >& _rxContext ); + explicit DataAccessDescriptorFactory( const Reference< XComponentContext >& _rxContext ); virtual ~DataAccessDescriptorFactory(); private: diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx b/dbaccess/source/core/dataaccess/databasecontext.cxx index 7523f29a2bab..b643646d1a7f 100644 --- a/dbaccess/source/core/dataaccess/databasecontext.cxx +++ b/dbaccess/source/core/dataaccess/databasecontext.cxx @@ -101,7 +101,7 @@ namespace dbaccess ::std::list< const ODatabaseModelImpl* > m_aDatabaseDocuments; public: - DatabaseDocumentLoader( const Reference & rxContext); + explicit DatabaseDocumentLoader( const Reference & rxContext); inline void append(const ODatabaseModelImpl& _rModelImpl ) { diff --git a/dbaccess/source/core/dataaccess/databasecontext.hxx b/dbaccess/source/core/dataaccess/databasecontext.hxx index 6665bf6007b1..512ae3309239 100644 --- a/dbaccess/source/core/dataaccess/databasecontext.hxx +++ b/dbaccess/source/core/dataaccess/databasecontext.hxx @@ -115,7 +115,7 @@ protected: DatabaseDocumentLoader* m_pDatabaseDocumentLoader; public: - ODatabaseContext( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& ); + explicit ODatabaseContext( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& ); virtual ~ODatabaseContext(); // OComponentHelper diff --git a/dbaccess/source/core/dataaccess/databasedocument.hxx b/dbaccess/source/core/dataaccess/databasedocument.hxx index aa7146ac681f..e8eacbdb3c96 100644 --- a/dbaccess/source/core/dataaccess/databasedocument.hxx +++ b/dbaccess/source/core/dataaccess/databasedocument.hxx @@ -82,7 +82,7 @@ typedef ::std::vector< ::com::sun::star::uno::Reference< ::com::sun::star::frame class ViewMonitor : public boost::noncopyable { public: - ViewMonitor( DocumentEventNotifier& _rEventNotifier ) + explicit ViewMonitor( DocumentEventNotifier& _rEventNotifier ) :m_rEventNotifier( _rEventNotifier ) ,m_bIsNewDocument( true ) ,m_bEverHadController( false ) @@ -272,7 +272,7 @@ class ODatabaseDocument :public ModelDependentComponent // ModelDepe const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >& _xComponent = ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >()); private: - ODatabaseDocument(const ::rtl::Reference& _pImpl); + explicit ODatabaseDocument(const ::rtl::Reference& _pImpl); // Do NOT create those documents directly, always use ODatabaseModelImpl::getModel. Reason is that // ODatabaseDocument requires clear ownership, and in turn lifetime synchronisation with the ModelImpl. // If you create a ODatabaseDocument directly, you might easily create a leak. diff --git a/dbaccess/source/core/dataaccess/databaseregistrations.cxx b/dbaccess/source/core/dataaccess/databaseregistrations.cxx index b5f3682d9308..97740a7b3320 100644 --- a/dbaccess/source/core/dataaccess/databaseregistrations.cxx +++ b/dbaccess/source/core/dataaccess/databaseregistrations.cxx @@ -74,7 +74,7 @@ namespace dbaccess ,public DatabaseRegistrations_Base { public: - DatabaseRegistrations( const Reference& _rxContext ); + explicit DatabaseRegistrations( const Reference& _rxContext ); protected: virtual ~DatabaseRegistrations(); diff --git a/dbaccess/source/core/dataaccess/datasource.cxx b/dbaccess/source/core/dataaccess/datasource.cxx index aa2115873d48..1c2764fe3190 100644 --- a/dbaccess/source/core/dataaccess/datasource.cxx +++ b/dbaccess/source/core/dataaccess/datasource.cxx @@ -305,7 +305,7 @@ protected: virtual ~OSharedConnectionManager(); public: - OSharedConnectionManager(const Reference< XComponentContext >& _rxContext); + explicit OSharedConnectionManager(const Reference< XComponentContext >& _rxContext); void SAL_CALL disposing( const ::com::sun::star::lang::EventObject& Source ) throw(RuntimeException, std::exception) SAL_OVERRIDE; Reference getConnection( const OUString& url, @@ -455,7 +455,7 @@ namespace const PropertyAttributeCache& m_rAttribs; public: - IsDefaultAndNotRemoveable( const PropertyAttributeCache& _rAttribs ) : m_rAttribs( _rAttribs ) { } + explicit IsDefaultAndNotRemoveable( const PropertyAttributeCache& _rAttribs ) : m_rAttribs( _rAttribs ) { } bool operator()( const PropertyValue& _rProp ) { diff --git a/dbaccess/source/core/dataaccess/datasource.hxx b/dbaccess/source/core/dataaccess/datasource.hxx index cc075cc231f5..bc4e19c96630 100644 --- a/dbaccess/source/core/dataaccess/datasource.hxx +++ b/dbaccess/source/core/dataaccess/datasource.hxx @@ -89,7 +89,7 @@ private: virtual ~ODatabaseSource(); public: - ODatabaseSource( const ::rtl::Reference< ODatabaseModelImpl >& _pImpl ); + explicit ODatabaseSource( const ::rtl::Reference< ODatabaseModelImpl >& _pImpl ); struct DBContextAccess { friend class ODatabaseContext; private: DBContextAccess() { } }; diff --git a/dbaccess/source/core/dataaccess/definitioncontainer.cxx b/dbaccess/source/core/dataaccess/definitioncontainer.cxx index 22c740187fed..e9034ce52a8b 100644 --- a/dbaccess/source/core/dataaccess/definitioncontainer.cxx +++ b/dbaccess/source/core/dataaccess/definitioncontainer.cxx @@ -257,7 +257,7 @@ namespace const ContainerEvent& m_rEvent; public: - RaiseExceptionFromVeto( ContainerApprovalMethod _pMethod, const ContainerEvent& _rEvent ) + explicit RaiseExceptionFromVeto( ContainerApprovalMethod _pMethod, const ContainerEvent& _rEvent ) :m_pMethod( _pMethod ) ,m_rEvent( _rEvent ) { diff --git a/dbaccess/source/core/dataaccess/documentcontainer.cxx b/dbaccess/source/core/dataaccess/documentcontainer.cxx index e38cf993d0b7..5cf5ecc2eb26 100644 --- a/dbaccess/source/core/dataaccess/documentcontainer.cxx +++ b/dbaccess/source/core/dataaccess/documentcontainer.cxx @@ -65,7 +65,7 @@ class LocalNameApproval : public IContainerApprove ::connectivity::SQLError m_aErrors; public: - LocalNameApproval( const Reference< XComponentContext >& _rxContext ) + explicit LocalNameApproval( const Reference< XComponentContext >& _rxContext ) :m_aErrors( _rxContext ) { } diff --git a/dbaccess/source/core/dataaccess/documentdefinition.cxx b/dbaccess/source/core/dataaccess/documentdefinition.cxx index 7aeb5a72dff0..0618f43463e4 100644 --- a/dbaccess/source/core/dataaccess/documentdefinition.cxx +++ b/dbaccess/source/core/dataaccess/documentdefinition.cxx @@ -225,7 +225,7 @@ namespace dbaccess { ODocumentDefinition* m_pClient; public: - OEmbeddedClientHelper(ODocumentDefinition* _pClient) :m_pClient(_pClient) {} + explicit OEmbeddedClientHelper(ODocumentDefinition* _pClient) :m_pClient(_pClient) {} virtual void SAL_CALL saveObject( ) throw (ObjectSaveVetoException, Exception, RuntimeException, std::exception) SAL_OVERRIDE { @@ -247,7 +247,7 @@ namespace dbaccess class LockModifiable { public: - LockModifiable( const Reference< XInterface >& i_rModifiable ) + explicit LockModifiable( const Reference< XInterface >& i_rModifiable ) :m_xModifiable( i_rModifiable, UNO_QUERY ) { OSL_ENSURE( m_xModifiable.is(), "LockModifiable::LockModifiable: invalid component!" ); @@ -555,7 +555,7 @@ class OExecuteImpl { bool& m_rbSet; public: - OExecuteImpl(bool& _rbSet) : m_rbSet(_rbSet){ m_rbSet=true; } + explicit OExecuteImpl(bool& _rbSet) : m_rbSet(_rbSet){ m_rbSet=true; } ~OExecuteImpl(){ m_rbSet = false; } }; @@ -633,7 +633,7 @@ namespace awt::Size m_aOriginalSize; public: - inline PreserveVisualAreaSize( const Reference< XModel >& _rxModel ) + explicit PreserveVisualAreaSize( const Reference< XModel >& _rxModel ) :m_xVisObject( _rxModel, UNO_QUERY ) { if ( m_xVisObject.is() ) @@ -674,7 +674,7 @@ namespace Reference< XLayoutManager > m_xLayoutManager; public: - inline LayoutManagerLock( const Reference< XController >& _rxController ) + explicit LayoutManagerLock( const Reference< XController >& _rxController ) { OSL_ENSURE( _rxController.is(), "LayoutManagerLock::LayoutManagerLock: this will crash!" ); Reference< XFrame > xFrame( _rxController->getFrame() ); diff --git a/dbaccess/source/core/dataaccess/documenteventexecutor.cxx b/dbaccess/source/core/dataaccess/documenteventexecutor.cxx index 5b6a4a9a4734..7cffb6277337 100644 --- a/dbaccess/source/core/dataaccess/documenteventexecutor.cxx +++ b/dbaccess/source/core/dataaccess/documenteventexecutor.cxx @@ -68,7 +68,7 @@ namespace dbaccess WeakReference< XEventsSupplier > xDocument; Reference< XURLTransformer > xURLTransformer; - DocumentEventExecutor_Data( const Reference< XEventsSupplier >& _rxDocument ) + explicit DocumentEventExecutor_Data( const Reference< XEventsSupplier >& _rxDocument ) :xDocument( _rxDocument ) { } diff --git a/dbaccess/source/core/dataaccess/intercept.hxx b/dbaccess/source/core/dataaccess/intercept.hxx index 85b6482008a7..ea2060cc7b0d 100644 --- a/dbaccess/source/core/dataaccess/intercept.hxx +++ b/dbaccess/source/core/dataaccess/intercept.hxx @@ -44,7 +44,7 @@ protected: virtual ~OInterceptor(); public: - OInterceptor( ODocumentDefinition* _pContentHolder ); + explicit OInterceptor( ODocumentDefinition* _pContentHolder ); void SAL_CALL dispose() throw(::com::sun::star::uno::RuntimeException); diff --git a/dbaccess/source/core/dataaccess/myucp_datasupplier.cxx b/dbaccess/source/core/dataaccess/myucp_datasupplier.cxx index aedd0ba27a6a..64eafad6f401 100644 --- a/dbaccess/source/core/dataaccess/myucp_datasupplier.cxx +++ b/dbaccess/source/core/dataaccess/myucp_datasupplier.cxx @@ -51,7 +51,7 @@ struct ResultListEntry Reference< XRow > xRow; const ContentProperties& rData; - ResultListEntry( const ContentProperties& rEntry ) : rData( rEntry ) {} + explicit ResultListEntry(const ContentProperties& rEntry) : rData( rEntry ) {} }; // ResultList. diff --git a/dbaccess/source/core/recovery/dbdocrecovery.cxx b/dbaccess/source/core/recovery/dbdocrecovery.cxx index e49def107a85..f7960e5e7a01 100644 --- a/dbaccess/source/core/recovery/dbdocrecovery.cxx +++ b/dbaccess/source/core/recovery/dbdocrecovery.cxx @@ -222,7 +222,7 @@ namespace dbaccess { const Reference aContext; - DatabaseDocumentRecovery_Data( const Reference & i_rContext ) + explicit DatabaseDocumentRecovery_Data( const Reference & i_rContext ) :aContext( i_rContext ) { } diff --git a/dbaccess/source/core/recovery/settingsimport.hxx b/dbaccess/source/core/recovery/settingsimport.hxx index dfd0ada47468..f72f87d5b9b7 100644 --- a/dbaccess/source/core/recovery/settingsimport.hxx +++ b/dbaccess/source/core/recovery/settingsimport.hxx @@ -94,7 +94,7 @@ namespace dbaccess class OfficeSettingsImport : public SettingsImport { public: - OfficeSettingsImport( ::comphelper::NamedValueCollection& o_rSettings ); + explicit OfficeSettingsImport( ::comphelper::NamedValueCollection& o_rSettings ); // SettingsImport overridables virtual ::rtl::Reference< SettingsImport > nextState( @@ -113,7 +113,7 @@ namespace dbaccess class ConfigItemImport : public SettingsImport { public: - ConfigItemImport( ::comphelper::NamedValueCollection& o_rSettings ); + explicit ConfigItemImport( ::comphelper::NamedValueCollection& o_rSettings ); protected: virtual ~ConfigItemImport(); @@ -139,7 +139,7 @@ namespace dbaccess class ConfigItemSetImport : public ConfigItemImport { public: - ConfigItemSetImport( ::comphelper::NamedValueCollection& o_rSettings ); + explicit ConfigItemSetImport( ::comphelper::NamedValueCollection& o_rSettings ); protected: virtual ~ConfigItemSetImport(); diff --git a/dbaccess/source/core/recovery/subcomponentloader.cxx b/dbaccess/source/core/recovery/subcomponentloader.cxx index 77869a6934c0..26ab2d05e5da 100644 --- a/dbaccess/source/core/recovery/subcomponentloader.cxx +++ b/dbaccess/source/core/recovery/subcomponentloader.cxx @@ -55,13 +55,13 @@ namespace dbaccess const Reference< XComponent > xNonDocComponent; Reference< XWindow > xAppComponentWindow; - SubComponentLoader_Data( const Reference< XCommandProcessor >& i_rDocumentDefinition ) + explicit SubComponentLoader_Data( const Reference< XCommandProcessor >& i_rDocumentDefinition ) :xDocDefCommands( i_rDocumentDefinition ) ,xNonDocComponent() { } - SubComponentLoader_Data( const Reference< XComponent >& i_rNonDocumentComponent ) + explicit SubComponentLoader_Data( const Reference< XComponent >& i_rNonDocumentComponent ) :xDocDefCommands() ,xNonDocComponent( i_rNonDocumentComponent ) { diff --git a/dbaccess/source/ext/macromigration/docinteraction.cxx b/dbaccess/source/ext/macromigration/docinteraction.cxx index 3faefe25d752..52700dab536d 100644 --- a/dbaccess/source/ext/macromigration/docinteraction.cxx +++ b/dbaccess/source/ext/macromigration/docinteraction.cxx @@ -53,7 +53,7 @@ namespace dbmm { Reference< XInteractionHandler > xHandler; - InteractionHandler_Data( const Reference& _rContext ) + explicit InteractionHandler_Data( const Reference& _rContext ) :xHandler( ::com::sun::star::task::InteractionHandler::createWithParent(_rContext, 0), UNO_QUERY ) { } diff --git a/dbaccess/source/ext/macromigration/macromigrationpages.hxx b/dbaccess/source/ext/macromigration/macromigrationpages.hxx index f9ee4d60dc4e..9c6cbb15f53d 100644 --- a/dbaccess/source/ext/macromigration/macromigrationpages.hxx +++ b/dbaccess/source/ext/macromigration/macromigrationpages.hxx @@ -56,7 +56,7 @@ namespace dbmm class PreparationPage : public MacroMigrationPage { public: - PreparationPage(vcl::Window *pParent); + explicit PreparationPage(vcl::Window *pParent); virtual ~PreparationPage(); virtual void dispose() SAL_OVERRIDE; @@ -73,7 +73,7 @@ namespace dbmm class SaveDBDocPage : public MacroMigrationPage { public: - SaveDBDocPage(MacroMigrationDialog& _rParentDialog); + explicit SaveDBDocPage(MacroMigrationDialog& _rParentDialog); virtual ~SaveDBDocPage(); virtual void dispose() SAL_OVERRIDE; static VclPtr Create( ::svt::RoadmapWizard& _rParentDialog ); @@ -103,7 +103,7 @@ namespace dbmm class ProgressPage : public MacroMigrationPage, public IMigrationProgress { public: - ProgressPage(vcl::Window *pParent); + explicit ProgressPage(vcl::Window *pParent); virtual ~ProgressPage(); virtual void dispose() SAL_OVERRIDE; @@ -136,7 +136,7 @@ namespace dbmm class ResultPage : public MacroMigrationPage { public: - ResultPage(vcl::Window *pParent); + explicit ResultPage(vcl::Window *pParent); virtual ~ResultPage(); virtual void dispose() SAL_OVERRIDE; -- cgit v1.2.3