From 3341435d7916c209c7613d594f78059ba112495b Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 25 May 2018 14:08:33 +0200 Subject: loplugin:passstuffbyref MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins Reviewed-by: Noel Grandin (cherry picked from commit ff3bdde2527123fc9e011ff0d93e958174632186) Reviewed-on: https://gerrit.libreoffice.org/54914 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- dbaccess/source/filter/hsqldb/alterparser.hxx | 6 +++--- dbaccess/source/filter/hsqldb/columndef.hxx | 4 ++-- dbaccess/source/filter/hsqldb/createparser.hxx | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) (limited to 'dbaccess') diff --git a/dbaccess/source/filter/hsqldb/alterparser.hxx b/dbaccess/source/filter/hsqldb/alterparser.hxx index 12b496a55df9..6f2e3535307e 100644 --- a/dbaccess/source/filter/hsqldb/alterparser.hxx +++ b/dbaccess/source/filter/hsqldb/alterparser.hxx @@ -32,9 +32,9 @@ private: protected: AlterAction getActionType() const { return m_eAction; } - OUString getColumnName() const { return m_sColumnName; } + OUString const& getColumnName() const { return m_sColumnName; } sal_Int32 getIdentityParam() const { return m_nIdentityParam; } - OUString getStatement() const { return m_sStmt; } + OUString const& getStatement() const { return m_sStmt; } public: virtual ~AlterStmtParser() = default; @@ -42,7 +42,7 @@ public: /** * @return name of the table which is to be created. */ - OUString getTableName() const { return m_sTableName; } + OUString const& getTableName() const { return m_sTableName; } void parse(const OUString& sSql); diff --git a/dbaccess/source/filter/hsqldb/columndef.hxx b/dbaccess/source/filter/hsqldb/columndef.hxx index 1700f7b29554..b356d3906b37 100644 --- a/dbaccess/source/filter/hsqldb/columndef.hxx +++ b/dbaccess/source/filter/hsqldb/columndef.hxx @@ -32,14 +32,14 @@ public: bool bPrimary = false, sal_Int32 nAutoIncr = -1, bool bNullable = true, bool bCaseInsensitive = false); - OUString getName() const { return m_sName; } + OUString const& getName() const { return m_sName; } sal_Int32 getDataType() const { return m_eType; } bool isPrimaryKey() const { return m_bPrimaryKey; } bool isNullable() const { return m_bNullable; } bool isAutoIncremental() const { return m_nAutoIncrement >= 0; } bool isCaseInsensitive() const { return m_bCaseInsensitive; } sal_Int32 getStartValue() const { return m_nAutoIncrement; } - const std::vector getParams() const { return m_aParams; } + const std::vector& getParams() const { return m_aParams; } }; } diff --git a/dbaccess/source/filter/hsqldb/createparser.hxx b/dbaccess/source/filter/hsqldb/createparser.hxx index 41db73797c2e..327cab869f01 100644 --- a/dbaccess/source/filter/hsqldb/createparser.hxx +++ b/dbaccess/source/filter/hsqldb/createparser.hxx @@ -34,12 +34,12 @@ public: /** * @return name of the table which is to be created. */ - OUString getTableName() const { return m_sTableName; } + OUString const& getTableName() const { return m_sTableName; } /** * @return primary keys of parsed table. */ - std::vector getPrimaryKeys() const { return m_PrimaryKeys; } + std::vector const& getPrimaryKeys() const { return m_PrimaryKeys; } /** * @return a vector of column descriptors, representing the columns of the -- cgit v1.2.3