From 97d50c425f83f05bb395956e1f855db00b979f27 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 16 May 2014 11:18:12 +0200 Subject: combine the pass-by-ref clang plugins Change-Id: Idac24afb7cb67fa2d539553fb9fa049c2d61ecf0 --- compilerplugins/clang/passsequencebyref.cxx | 63 ----------------------- compilerplugins/clang/passstringbyref.cxx | 71 -------------------------- compilerplugins/clang/passstuffbyref.cxx | 78 +++++++++++++++++++++++++++++ 3 files changed, 78 insertions(+), 134 deletions(-) delete mode 100644 compilerplugins/clang/passsequencebyref.cxx delete mode 100644 compilerplugins/clang/passstringbyref.cxx create mode 100644 compilerplugins/clang/passstuffbyref.cxx (limited to 'compilerplugins') diff --git a/compilerplugins/clang/passsequencebyref.cxx b/compilerplugins/clang/passsequencebyref.cxx deleted file mode 100644 index 851307bb2710..000000000000 --- a/compilerplugins/clang/passsequencebyref.cxx +++ /dev/null @@ -1,63 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - */ - -#include - -#include "plugin.hxx" - -// Find places where com::sun::star::uno::Sequence is passed by value. -// It's not very efficient, because that copies a whole list -// They should rather be passed by reference. - -namespace { - -class PassSequenceByRef: - public RecursiveASTVisitor, public loplugin::Plugin -{ -public: - explicit PassSequenceByRef(InstantiationData const & data): Plugin(data) {} - - virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); } - - bool VisitFunctionDecl(const FunctionDecl * decl); -}; - -bool PassSequenceByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) { - if (ignoreLocation(functionDecl)) { - return true; - } - // only warn on the definition/prototype of the function, - // not on the function implementation - if (functionDecl->isThisDeclarationADefinition() && functionDecl->getPreviousDecl() != nullptr) { - return true; - } - unsigned n = functionDecl->getNumParams(); - for (unsigned i = 0; i != n; ++i) { - const ParmVarDecl * pvDecl = functionDecl->getParamDecl(i); - QualType t1 { pvDecl->getType() }; - if (!t1->isClassType()) { - continue; - } - string typeName = t1.getUnqualifiedType().getCanonicalType().getAsString(); - if (typeName.find("class com::sun::star::uno::Sequence") == 0) { - report( - DiagnosticsEngine::Warning, - "passing css::uno::Sequence by value, rather pass by reference .e.g. 'const css::uno::Sequence&' " + typeName, - pvDecl->getSourceRange().getBegin()) - << pvDecl->getSourceRange(); - } - } - return true; -} - -loplugin::Plugin::Registration< PassSequenceByRef > X("passsequencebyref"); - -} - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/compilerplugins/clang/passstringbyref.cxx b/compilerplugins/clang/passstringbyref.cxx deleted file mode 100644 index 50e1a859fb11..000000000000 --- a/compilerplugins/clang/passstringbyref.cxx +++ /dev/null @@ -1,71 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - */ - -#include - -#include "plugin.hxx" - -// Find places where OUString and OString are passed by value. -// It's not very efficient, because we generally end up copying it twice - once into the parameter and -// again into the destination OUString. -// They should rather be passed by reference. - -namespace { - -class PassStringByRef: - public RecursiveASTVisitor, public loplugin::Plugin -{ -public: - explicit PassStringByRef(InstantiationData const & data): Plugin(data) {} - - virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); } - - bool VisitFunctionDecl(const FunctionDecl * decl); -}; - -bool PassStringByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) { - if (ignoreLocation(functionDecl)) { - return true; - } - // only warn on the definition/prototype of the function, - // not on the function implementation - if (functionDecl->isThisDeclarationADefinition() && functionDecl->getPreviousDecl() != nullptr) { - return true; - } - unsigned n = functionDecl->getNumParams(); - for (unsigned i = 0; i != n; ++i) { - const ParmVarDecl * pvDecl = functionDecl->getParamDecl(i); - QualType t1 { pvDecl->getType() }; - if (!t1->isClassType()) { - continue; - } - string typeName = t1.getUnqualifiedType().getCanonicalType().getAsString(); - if (typeName == "class rtl::OUString") { - report( - DiagnosticsEngine::Warning, - "passing OUString by value, rather pass by reference .e.g. 'const OUString&'", - pvDecl->getSourceRange().getBegin()) - << pvDecl->getSourceRange(); - } - else if (typeName == "class rtl::OString") { - report( - DiagnosticsEngine::Warning, - "passing OString by value, rather pass by reference .e.g. 'const OString&'", - pvDecl->getSourceRange().getBegin()) - << pvDecl->getSourceRange(); - } - } - return true; -} - -loplugin::Plugin::Registration< PassStringByRef > X("passstringbyref"); - -} - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/compilerplugins/clang/passstuffbyref.cxx b/compilerplugins/clang/passstuffbyref.cxx new file mode 100644 index 000000000000..c4951e82ca7c --- /dev/null +++ b/compilerplugins/clang/passstuffbyref.cxx @@ -0,0 +1,78 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include + +#include "plugin.hxx" + +// Find places where various things are passed by value. +// It's not very efficient, because we generally end up copying it twice - once into the parameter and +// again into the destination. +// They should rather be passed by reference. + +namespace { + +class PassStuffByRef: + public RecursiveASTVisitor, public loplugin::Plugin +{ +public: + explicit PassStuffByRef(InstantiationData const & data): Plugin(data) {} + + virtual void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); } + + bool VisitFunctionDecl(const FunctionDecl * decl); +}; + +bool PassStuffByRef::VisitFunctionDecl(const FunctionDecl * functionDecl) { + if (ignoreLocation(functionDecl)) { + return true; + } + // only warn on the definition/prototype of the function, + // not on the function implementation + if (functionDecl->isThisDeclarationADefinition() && functionDecl->getPreviousDecl() != nullptr) { + return true; + } + unsigned n = functionDecl->getNumParams(); + for (unsigned i = 0; i != n; ++i) { + const ParmVarDecl * pvDecl = functionDecl->getParamDecl(i); + QualType t1 { pvDecl->getType() }; + if (!t1->isClassType()) { + continue; + } + string typeName = t1.getUnqualifiedType().getCanonicalType().getAsString(); + if (typeName == "class rtl::OUString") { + report( + DiagnosticsEngine::Warning, + "passing OUString by value, rather pass by reference .e.g. 'const OUString&'", + pvDecl->getSourceRange().getBegin()) + << pvDecl->getSourceRange(); + } + else if (typeName == "class rtl::OString") { + report( + DiagnosticsEngine::Warning, + "passing OString by value, rather pass by reference .e.g. 'const OString&'", + pvDecl->getSourceRange().getBegin()) + << pvDecl->getSourceRange(); + } + else if (typeName.find("class com::sun::star::uno::Sequence") == 0) { + report( + DiagnosticsEngine::Warning, + "passing css::uno::Sequence by value, rather pass by reference .e.g. 'const css::uno::Sequence&' " + typeName, + pvDecl->getSourceRange().getBegin()) + << pvDecl->getSourceRange(); + } + } + return true; +} + +loplugin::Plugin::Registration< PassStuffByRef > X("passstuffbyref"); + +} + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- cgit v1.2.3