From c1fbdc8717fa68f4c432511ace8b58c97b1386ad Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 28 Nov 2019 13:42:29 +0100 Subject: Document fishy loplugin:fakebool behavior ...as exploited in the change of LockingGuard (extensions/source/activex/SOActiveX.cxx) in 55e596956e56b175ab17b682e7c8ac7daeb9289a "loplugin:external (clang-cl)" Change-Id: I599ac72b68651fc733dd37c95ce9105c175fee9e Reviewed-on: https://gerrit.libreoffice.org/83995 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- compilerplugins/clang/test/fakebool.cxx | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'compilerplugins/clang/test') diff --git a/compilerplugins/clang/test/fakebool.cxx b/compilerplugins/clang/test/fakebool.cxx index 26b5d7e2f791..936e970e5e85 100644 --- a/compilerplugins/clang/test/fakebool.cxx +++ b/compilerplugins/clang/test/fakebool.cxx @@ -17,6 +17,20 @@ struct S { sal_Bool b; // expected-error {{FieldDecl, use "bool" instead of 'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}} }; +struct S2 { + sal_Bool & b_; + // The following should arguably not warn, but currently does (and does find cases that actually + // can be cleaned up; if it ever produces false warnings for cases that cannot, we need to fix + // it): + S2(sal_Bool & b): // expected-error {{ParmVarDecl, use "bool" instead of 'sal_Bool' (aka 'unsigned char') [loplugin:fakebool]}} + b_(b) {} +}; + } +struct S3 { + sal_Bool b_; + void f() { S2 s(b_); } +}; + /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ -- cgit v1.2.3