From 18dda8ed5ec0d77648e795ba995a324d0cbbdeca Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 26 May 2021 14:44:02 +0100 Subject: tdf#142467 crash on calling 'getInfoHelper' in final class IPropertyArrayHelper & rInfo = getInfoHelper(); crashes when CandleStickChartType is final for unknown reasons. I see this with gcc-11.1.1-1.fc34.x86_64 in 7-1 locally but also in the fedora libreoffice-7.0.6 built with gcc-10 so this isn't a recent problem. #1 0x00007ffff6f4fe91 in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=this@entry=0x5bdd588, nHandle=nHandle@entry=3) at cppuhelper/source/propshlp.cxx:549 #2 0x00007fffad45e9ff in chart::CandleStickChartType::getSupportedMandatoryRoles() (this=0x5bdd520) at chart2/source/model/template/CandleStickChartType.cxx:219 Change-Id: Ia029162587da1fc00df32866863deb186c7e11bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116153 Tested-by: Jenkins Reviewed-by: Xisco Fauli --- chart2/source/model/template/CandleStickChartType.hxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'chart2') diff --git a/chart2/source/model/template/CandleStickChartType.hxx b/chart2/source/model/template/CandleStickChartType.hxx index 00c2747bc7af..969c14c24d35 100644 --- a/chart2/source/model/template/CandleStickChartType.hxx +++ b/chart2/source/model/template/CandleStickChartType.hxx @@ -23,7 +23,8 @@ namespace chart { -class CandleStickChartType final : public ChartType +// see tdf#142467 before restoring 'final' +class CandleStickChartType /* final */ : public ChartType { public: explicit CandleStickChartType(); -- cgit v1.2.3