From 0063cf285696951e336b9cec1da8881997b286ce Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 18 Nov 2014 10:01:21 +0200 Subject: java: make fields final where possible found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec --- bean/com/sun/star/comp/beans/Controller.java | 4 ++-- bean/com/sun/star/comp/beans/Frame.java | 6 +++--- bean/com/sun/star/comp/beans/LocalOfficeConnection.java | 6 +++--- bean/com/sun/star/comp/beans/OfficeDocument.java | 8 ++++---- bean/com/sun/star/comp/beans/Wrapper.java | 4 ++-- 5 files changed, 14 insertions(+), 14 deletions(-) (limited to 'bean/com') diff --git a/bean/com/sun/star/comp/beans/Controller.java b/bean/com/sun/star/comp/beans/Controller.java index 9e93c5878b2f..91f64db874c4 100644 --- a/bean/com/sun/star/comp/beans/Controller.java +++ b/bean/com/sun/star/comp/beans/Controller.java @@ -29,8 +29,8 @@ public class Controller implements com.sun.star.frame.XController { - private com.sun.star.frame.XController xController; - private com.sun.star.frame.XDispatchProvider xDispatchProvider; + private final com.sun.star.frame.XController xController; + private final com.sun.star.frame.XDispatchProvider xDispatchProvider; Controller( com.sun.star.frame.XController xController ) { diff --git a/bean/com/sun/star/comp/beans/Frame.java b/bean/com/sun/star/comp/beans/Frame.java index 59ccf2613245..fbf9ca97ef51 100644 --- a/bean/com/sun/star/comp/beans/Frame.java +++ b/bean/com/sun/star/comp/beans/Frame.java @@ -31,9 +31,9 @@ public class Frame com.sun.star.frame.XDispatchProvider, com.sun.star.frame.XDispatchProviderInterception { - private com.sun.star.frame.XFrame xFrame; - private com.sun.star.frame.XDispatchProvider xDispatchProvider; - private com.sun.star.frame.XDispatchProviderInterception xDispatchProviderInterception; + private final com.sun.star.frame.XFrame xFrame; + private final com.sun.star.frame.XDispatchProvider xDispatchProvider; + private final com.sun.star.frame.XDispatchProviderInterception xDispatchProviderInterception; public Frame( com.sun.star.frame.XFrame xFrame ) { diff --git a/bean/com/sun/star/comp/beans/LocalOfficeConnection.java b/bean/com/sun/star/comp/beans/LocalOfficeConnection.java index c81796daebe7..5a57dcdc8e79 100644 --- a/bean/com/sun/star/comp/beans/LocalOfficeConnection.java +++ b/bean/com/sun/star/comp/beans/LocalOfficeConnection.java @@ -62,7 +62,7 @@ public class LocalOfficeConnection private String mProtocol; private String mInitialObject; - private List mComponents = new ArrayList(); + private final List mComponents = new ArrayList(); private static long m_nBridgeCounter = 0; @@ -742,8 +742,8 @@ public class LocalOfficeConnection private class StreamProcessor extends Thread { - private java.io.InputStream m_in; - private java.io.PrintStream m_print; + private final java.io.InputStream m_in; + private final java.io.PrintStream m_print; public StreamProcessor(final java.io.InputStream in, final java.io.PrintStream out) { diff --git a/bean/com/sun/star/comp/beans/OfficeDocument.java b/bean/com/sun/star/comp/beans/OfficeDocument.java index a84689901f5c..10ee1ef24061 100644 --- a/bean/com/sun/star/comp/beans/OfficeDocument.java +++ b/bean/com/sun/star/comp/beans/OfficeDocument.java @@ -37,10 +37,10 @@ public class OfficeDocument extends Wrapper com.sun.star.frame.XStorable, com.sun.star.view.XPrintable { - private com.sun.star.frame.XModel xModel; - private com.sun.star.util.XModifiable xModifiable; - private com.sun.star.view.XPrintable xPrintable; - private com.sun.star.frame.XStorable xStorable; + private final com.sun.star.frame.XModel xModel; + private final com.sun.star.util.XModifiable xModifiable; + private final com.sun.star.view.XPrintable xPrintable; + private final com.sun.star.frame.XStorable xStorable; public OfficeDocument( com.sun.star.frame.XModel xModel ) { diff --git a/bean/com/sun/star/comp/beans/Wrapper.java b/bean/com/sun/star/comp/beans/Wrapper.java index 837601842e48..001770b9b230 100644 --- a/bean/com/sun/star/comp/beans/Wrapper.java +++ b/bean/com/sun/star/comp/beans/Wrapper.java @@ -45,8 +45,8 @@ class Wrapper com.sun.star.uno.IQueryInterface, com.sun.star.lang.XComponent { - private com.sun.star.uno.IQueryInterface xQueryInterface; - private com.sun.star.lang.XComponent xComponent; + private final com.sun.star.uno.IQueryInterface xQueryInterface; + private final com.sun.star.lang.XComponent xComponent; public Wrapper( com.sun.star.uno.XInterface xProxy ) { -- cgit v1.2.1