From b839cccb63fd3a48611ac7ab07a2cd14e5ed5822 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 23 Nov 2016 18:37:02 +0100 Subject: loplugin:unnecessaryoverride (dtors) in basic Change-Id: I5756b96bcc7563b82e35d3cdfdda3b80692767e5 (cherry picked from commit f338935019ab8e0b19cf7b7ce5151d7cf73e9383) (cherry picked from commit 2e480f692681eff43c897f1e6d4439583b48e634) --- basic/qa/cppunit/test_vba.cxx | 1 - basic/source/classes/errobject.cxx | 7 +------ basic/source/classes/sbunoobj.cxx | 9 --------- basic/source/classes/sbxmod.cxx | 5 ----- 4 files changed, 1 insertion(+), 21 deletions(-) (limited to 'basic') diff --git a/basic/qa/cppunit/test_vba.cxx b/basic/qa/cppunit/test_vba.cxx index 4e5adc312d58..4028ec461a40 100644 --- a/basic/qa/cppunit/test_vba.cxx +++ b/basic/qa/cppunit/test_vba.cxx @@ -25,7 +25,6 @@ namespace { public: VBATest() : BootstrapFixture(true, false) {} - virtual ~VBATest() override {} void testMiscVBAFunctions(); void testMiscOLEStuff(); // Adds code needed to register the test suite diff --git a/basic/source/classes/errobject.cxx b/basic/source/classes/errobject.cxx index ddeb1aee585b..19f121327927 100644 --- a/basic/source/classes/errobject.cxx +++ b/basic/source/classes/errobject.cxx @@ -38,7 +38,7 @@ class ErrObject : public ::cppu::WeakImplHelper< vba::XErrObject, public: ErrObject(); - virtual ~ErrObject() override; + // Attributes virtual ::sal_Int32 SAL_CALL getNumber() throw (uno::RuntimeException, std::exception) override; virtual void SAL_CALL setNumber( ::sal_Int32 _number ) throw (uno::RuntimeException, std::exception) override; @@ -62,11 +62,6 @@ public: const uno::Any& HelpFile, const uno::Any& HelpContext ) throw (uno::RuntimeException); }; - -ErrObject::~ErrObject() -{ -} - ErrObject::ErrObject() : m_nNumber(0), m_nHelpContext(0) { } diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx index d4ccf6d3b98d..e87d267823fc 100644 --- a/basic/source/classes/sbunoobj.cxx +++ b/basic/source/classes/sbunoobj.cxx @@ -3826,7 +3826,6 @@ public: OUString aPrefixName; explicit BasicAllListener_Impl( const OUString& aPrefixName ); - virtual ~BasicAllListener_Impl() override; // Methods of XAllListener virtual void SAL_CALL firing(const AllEventObject& Event) throw ( RuntimeException, std::exception ) override; @@ -3842,12 +3841,6 @@ BasicAllListener_Impl::BasicAllListener_Impl(const OUString& aPrefixName_) { } - -BasicAllListener_Impl::~BasicAllListener_Impl() -{ -} - - void BasicAllListener_Impl::firing_impl( const AllEventObject& Event, Any* pRet ) { SolarMutexGuard guard; @@ -4249,8 +4242,6 @@ class ModuleInvocationProxy : public WeakImplHelper< XInvocation, XComponent > public: ModuleInvocationProxy( const OUString& aPrefix, SbxObjectRef xScopeObj ); - virtual ~ModuleInvocationProxy() override - {} // XInvocation virtual Reference< XIntrospectionAccess > SAL_CALL getIntrospection() throw(std::exception) override; diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx index 5acd71e9482c..fef122064dc2 100644 --- a/basic/source/classes/sbxmod.cxx +++ b/basic/source/classes/sbxmod.cxx @@ -99,7 +99,6 @@ class DocObjectWrapper : public DocObjectWrapper_BASE public: explicit DocObjectWrapper( SbModule* pMod ); - virtual ~DocObjectWrapper() override; virtual void SAL_CALL acquire() throw() override; virtual void SAL_CALL release() throw() override; @@ -185,10 +184,6 @@ DocObjectWrapper::release() throw () OWeakObject::release(); } -DocObjectWrapper::~DocObjectWrapper() -{ -} - Sequence< Type > SAL_CALL DocObjectWrapper::getTypes() throw ( RuntimeException, std::exception ) { -- cgit v1.2.3