From cbbb24d0afcdbdac21d03ec4ee1455a3834afff4 Mon Sep 17 00:00:00 2001 From: Julien Nabet Date: Mon, 13 Apr 2015 20:10:16 +0200 Subject: tdf#90566: memory leak: maChangeListeners is not properly disposed + exchange arguments of swap to use the same pattern as the other swap locations Thank you Mike Kaganski! Change-Id: Ie575d503349b3218c7a0211e1f81d791e995297e --- sfx2/source/sidebar/Theme.cxx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sfx2/source/sidebar/Theme.cxx b/sfx2/source/sidebar/Theme.cxx index 03dd0c1946ac..c3596b13bca3 100644 --- a/sfx2/source/sidebar/Theme.cxx +++ b/sfx2/source/sidebar/Theme.cxx @@ -390,13 +390,13 @@ void Theme::UpdateTheme (void) void SAL_CALL Theme::disposing (void) { ChangeListeners aListeners; - maChangeListeners.swap(aListeners); + aListeners.swap(maChangeListeners); const lang::EventObject aEvent (static_cast(this)); for (ChangeListeners::const_iterator - iContainer(maChangeListeners.begin()), - iContainerEnd(maChangeListeners.end()); + iContainer(aListeners.begin()), + iContainerEnd(aListeners.end()); iContainer != iContainerEnd; ++iContainer) { -- cgit v1.2.3