From c9faab624519a1ecc35dcfe4126886b1c3ceddc6 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 19 Apr 2018 15:05:22 +0200 Subject: loplugin:unnecessaryvirtual Change-Id: Ieecb426f4f839bb1f94e58e45a99643a74ec3009 Reviewed-on: https://gerrit.libreoffice.org/53165 Tested-by: Jenkins Reviewed-by: Noel Grandin --- compilerplugins/clang/unnecessaryvirtual.results | 50 ++++-------------------- include/svx/svdpage.hxx | 2 +- 2 files changed, 9 insertions(+), 43 deletions(-) diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results index e2ccd60c5a6b..8e8c84672159 100644 --- a/compilerplugins/clang/unnecessaryvirtual.results +++ b/compilerplugins/clang/unnecessaryvirtual.results @@ -1,7 +1,3 @@ -accessibility/inc/standard/accessiblemenuitemcomponent.hxx:41 - void OAccessibleMenuItemComponent::Select() -accessibility/inc/standard/accessiblemenuitemcomponent.hxx:42 - void OAccessibleMenuItemComponent::DeSelect() basic/source/comp/codegen.cxx:464 void OffSetAccumulator::start(const unsigned char *,) basic/source/comp/codegen.cxx:465 @@ -28,28 +24,6 @@ basic/source/comp/codegen.cxx:529 void BufferTransformer::end() chart2/source/inc/WeakListenerAdapter.hxx:58 void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) -chart2/source/view/axes/Tickmarks.hxx:133 - void chart::TickFactory2D::updateScreenValues(class std::__debug::vector >, class std::allocator > > > &,)const -dbaccess/source/core/api/CRowSetDataColumn.hxx:73 - void dbaccess::ORowSetDataColumn::fireValueChange(const class connectivity::ORowSetValue &,) -dbaccess/source/core/api/KeySet.hxx:190 - _Bool dbaccess::OKeySet::isBeforeFirst() -dbaccess/source/core/api/KeySet.hxx:191 - _Bool dbaccess::OKeySet::isAfterLast() -dbaccess/source/core/api/RowSet.hxx:238 - void dbaccess::ORowSet::notifyAllListeners(class osl::ResettableGuard &,) -dbaccess/source/core/api/StaticSet.hxx:56 - _Bool dbaccess::OStaticSet::isBeforeFirst() -dbaccess/source/core/api/StaticSet.hxx:57 - _Bool dbaccess::OStaticSet::isAfterLast() -dbaccess/source/core/recovery/storagexmlstream.hxx:46 - void dbaccess::StorageXMLOutputStream::close() -dbaccess/source/ui/inc/RTableConnectionData.hxx:49 - class rtl::Reference dbaui::ORelationTableConnectionData::CreateLineDataObj() -dbaccess/source/ui/inc/unodatbr.hxx:208 - void dbaui::SbaTableQueryBrowser::InitializeGridModel(const class com::sun::star::uno::Reference &,) -dbaccess/source/ui/querydesign/QTableConnectionData.hxx:36 - class rtl::Reference dbaui::OQueryTableConnectionData::CreateLineDataObj() extensions/source/dbpilots/unoautopilot.hxx:98 class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const extensions/source/propctrlr/commoncontrol.hxx:127 @@ -82,13 +56,9 @@ forms/source/xforms/namedcollection.hxx:106 class com::sun::star::uno::Sequence NamedCollection::getElementNames() forms/source/xforms/namedcollection.hxx:111 unsigned char NamedCollection::hasByName(const class rtl::OUString &,) -hwpfilter/source/hbox.h:159 - class std::basic_string, class std::allocator > DateCode::GetString() -hwpfilter/source/hbox.h:834 - class std::basic_string, class std::allocator > MailMerge::GetString() include/basegfx/utils/unopolypolygon.hxx:97 void basegfx::unotools::UnoPolyPolygon::modifying()const -include/comphelper/interaction.hxx:55 +include/comphelper/interaction.hxx:54 void comphelper::OInteraction::select() include/comphelper/proparrhlp.hxx:87 class cppu::IPropertyArrayHelper * comphelper::OAggregationArrayUsageHelper::createArrayHelper()const @@ -148,9 +118,11 @@ include/svl/svdde.hxx:251 _Bool DdeTopic::StartAdviseLoop() include/svl/svdde.hxx:307 void DdeService::~DdeService() -include/svtools/treelistbox.hxx:723 +include/svtools/treelistbox.hxx:722 void SvTreeListBox::SelectAll(_Bool,_Bool,) -include/toolkit/controls/geometrycontrolmodel.hxx:192 +include/svx/svdpage.hxx:94 + class SdrObjList * SdrObjList::CloneSdrObjList(class SdrModel *,)const +include/toolkit/controls/geometrycontrolmodel.hxx:191 void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence &,class com::sun::star::uno::Sequence &,)const include/vbahelper/vbacollectionimpl.hxx:290 int ScVbaCollectionBase::getCount() @@ -174,19 +146,13 @@ include/vbahelper/vbareturntypes.hxx:40 void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,) include/vbahelper/vbareturntypes.hxx:41 type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue() -include/vcl/weld.hxx:219 +include/vcl/weld.hxx:267 void weld::TreeView::append_text(const class rtl::OUString &,) -include/vcl/weld.hxx:222 +include/vcl/weld.hxx:270 void weld::TreeView::append(const class rtl::OUString &,const class rtl::OUString &,const class rtl::OUString &,) sc/source/core/opencl/formulagroupcl.cxx:870 void sc::opencl::DynamicKernelMixedArgument::GenNumDeclRef(class std::basic_stringstream &,)const -sc/source/core/opencl/formulagroupcl.cxx:929 - class std::basic_string, class std::allocator > sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowDeclRef(_Bool,)const -sc/source/core/opencl/formulagroupcl.cxx:952 - unsigned long sc::opencl::DynamicKernelSlidingArgument::GenReductionLoopHeader(class std::basic_stringstream &,_Bool &,) -sc/source/core/opencl/formulagroupcl.cxx:1190 - unsigned long sc::opencl::ParallelReductionVectorRef::GenReductionLoopHeader(class std::basic_stringstream &,int,_Bool &,) -sc/source/ui/inc/anyrefdg.hxx:220 +sc/source/ui/inc/anyrefdg.hxx:219 void ScRefHdlrImpl::dispose() sc/source/ui/vba/vbacondition.hxx:39 class rtl::OUString ScVbaCondition::Formula1() diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx index 3e8fcb54f880..a6ab2f97229f 100644 --- a/include/svx/svdpage.hxx +++ b/include/svx/svdpage.hxx @@ -91,7 +91,7 @@ private: public: SdrObjList(SdrPage* pNewPage = nullptr); virtual ~SdrObjList(); - virtual SdrObjList* CloneSdrObjList(SdrModel* pNewModel = nullptr) const; + SdrObjList* CloneSdrObjList(SdrModel* pNewModel = nullptr) const; void CopyObjects(const SdrObjList& rSrcList, SdrModel* pNewModel = nullptr); /// clean up everything (without Undo) -- cgit v1.2.3