From b5f3f55ce59b400f885c41413a3087e3406a424d Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Tue, 18 Jun 2013 20:02:13 +0200 Subject: fdo#43460 unoxml,writerfilter,xmlsecurity: use isEmpty() Change-Id: Iba3b39086212803bc41384f5c8f51e42712a5249 Reviewed-on: https://gerrit.libreoffice.org/4349 Reviewed-by: Noel Power Tested-by: Noel Power --- unoxml/source/dom/element.cxx | 2 +- writerfilter/source/rtftok/rtfdocumentimpl.cxx | 6 +++--- xmlsecurity/source/dialogs/resourcemanager.cxx | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/unoxml/source/dom/element.cxx b/unoxml/source/dom/element.cxx index 50bb0bd27db2..87dba8a0a37c 100644 --- a/unoxml/source/dom/element.cxx +++ b/unoxml/source/dom/element.cxx @@ -502,7 +502,7 @@ namespace DOM Reference< XAttr > aAttr; if (!oldAttr->getNamespaceURI().isEmpty()) { OUStringBuffer qname(oldAttr->getPrefix()); - if (0 != qname.getLength()) { + if (!qname.isEmpty()) { qname.append(sal_Unicode(':')); } qname.append(oldAttr->getName()); diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index 8bd05dc5d2b8..8849ed718ebc 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -1237,7 +1237,7 @@ int RTFDocumentImpl::dispatchDestination(RTFKeyword nKeyword) aBuf.append(ch); else if (bInKeyword && isspace(ch)) bInKeyword = false; - if (aBuf.getLength() > 0 && !isalnum(ch)) + if (!aBuf.isEmpty() && !isalnum(ch)) bFoundCode = true; } Strm().Seek(nPos); @@ -4649,12 +4649,12 @@ void RTFDocumentImpl::setSkipUnknown(bool bSkipUnknown) void RTFDocumentImpl::checkUnicode(bool bUnicode, bool bHex) { - if (bUnicode && m_aUnicodeBuffer.getLength() > 0) + if (bUnicode && !m_aUnicodeBuffer.isEmpty()) { OUString aString = m_aUnicodeBuffer.makeStringAndClear(); text(aString); } - if (bHex && m_aHexBuffer.getLength() > 0) + if (bHex && !m_aHexBuffer.isEmpty()) { OUString aString = OStringToOUString(m_aHexBuffer.makeStringAndClear(), m_aStates.top().nCurrentEncoding); text(aString); diff --git a/xmlsecurity/source/dialogs/resourcemanager.cxx b/xmlsecurity/source/dialogs/resourcemanager.cxx index 2611960df028..d9279b1fa335 100644 --- a/xmlsecurity/source/dialogs/resourcemanager.cxx +++ b/xmlsecurity/source/dialogs/resourcemanager.cxx @@ -284,7 +284,7 @@ vector< pair< OUString, OUString> > parseDN(const OUString& rRawString) } } } - if (sbufValue.getLength()) + if (!sbufValue.isEmpty()) { OSL_ASSERT(!sType.isEmpty()); retVal.push_back(make_pair(sType, sbufValue.makeStringAndClear())); -- cgit v1.2.3