From af32de21ade9d6d3b7a92f5988b4c8074489be14 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Fri, 20 Mar 2020 17:54:02 +0100 Subject: sw pad-to-4 numbering: add DOCX filter Now that style::NumberingType::ARABIC_ZERO3 is already handled, this is much easier. (cherry picked from commit d7b6269bd5414ca0aa502a2fef7a838bcfbc1161) Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport14.cxx Change-Id: Ibe76d90253a5bfad84560395502590a380d559d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91639 Tested-by: Jenkins CollaboraOffice Reviewed-by: Miklos Vajna --- .../extras/ooxmlexport/data/arabic-zero4-numbering.docx | Bin 0 -> 5238 bytes sw/qa/extras/ooxmlexport/ooxmlexport13.cxx | 13 +++++++++++++ sw/source/filter/ww8/docxattributeoutput.cxx | 4 ++++ writerfilter/source/dmapper/ConversionHelper.cxx | 4 ++++ 4 files changed, 21 insertions(+) create mode 100644 sw/qa/extras/ooxmlexport/data/arabic-zero4-numbering.docx diff --git a/sw/qa/extras/ooxmlexport/data/arabic-zero4-numbering.docx b/sw/qa/extras/ooxmlexport/data/arabic-zero4-numbering.docx new file mode 100644 index 000000000000..6779d85989a9 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/arabic-zero4-numbering.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx index a4ad95ff7901..e43d5f5cb8c2 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx @@ -626,6 +626,19 @@ DECLARE_ODFEXPORT_TEST(testArabicZero3Numbering, "arabic-zero3-numbering.docx") aMap["NumberingType"].get()); } +DECLARE_ODFEXPORT_TEST(testArabicZero4Numbering, "arabic-zero4-numbering.docx") +{ + auto xNumberingRules + = getProperty>(getParagraph(1), "NumberingRules"); + comphelper::SequenceAsHashMap aMap(xNumberingRules->getByIndex(0)); + // Without the accompanying fix in place, this test would have failed with: + // - Expected: 66 + // - Actual : 4 + // i.e. numbering type was ARABIC, not ARABIC_ZERO4. + CPPUNIT_ASSERT_EQUAL(static_cast(style::NumberingType::ARABIC_ZERO4), + aMap["NumberingType"].get()); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 9ae8d551668e..126f366943ff 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -6496,6 +6496,10 @@ static OString impl_LevelNFC(sal_uInt16 nNumberingType, const SfxItemSet* pOutSe aType = "custom"; rFormat = "001, 002, 003, ..."; break; + case style::NumberingType::ARABIC_ZERO4: + aType = "custom"; + rFormat = "0001, 0002, 0003, ..."; + break; /* Fallback the rest to decimal. case style::NumberingType::NATIVE_NUMBERING: diff --git a/writerfilter/source/dmapper/ConversionHelper.cxx b/writerfilter/source/dmapper/ConversionHelper.cxx index 694bf956cc6e..ad8c5190d882 100644 --- a/writerfilter/source/dmapper/ConversionHelper.cxx +++ b/writerfilter/source/dmapper/ConversionHelper.cxx @@ -622,6 +622,10 @@ sal_Int16 ConvertCustomNumberFormat(const OUString& rFormat) { nRet = style::NumberingType::ARABIC_ZERO3; } + else if (rFormat == "0001, 0002, 0003, ...") + { + nRet = style::NumberingType::ARABIC_ZERO4; + } return nRet; } -- cgit v1.2.3