From 4198d04df49cff31f509b219293e5e18f7499e05 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 18 Nov 2020 16:43:39 +0000 Subject: crashtesting: make tdf129410-1.ods not crash on load MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Give its multiple anonymous ChartListeners unique names Maybe ScMyOLEFixer::FixupOLEs should instead skip calling CreateChartListener if getPropertyValue(sPersistName) >>= sName succeeded but has an empty sName result. Change-Id: I0741694ee692aaa22e0441a5e09748eb67e8dbf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106066 Tested-by: Jenkins Reviewed-by: Caolán McNamara --- sc/source/filter/xml/XMLTableShapeResizer.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sc/source/filter/xml/XMLTableShapeResizer.cxx b/sc/source/filter/xml/XMLTableShapeResizer.cxx index 61b651a94a0b..3a0f466aa590 100644 --- a/sc/source/filter/xml/XMLTableShapeResizer.cxx +++ b/sc/source/filter/xml/XMLTableShapeResizer.cxx @@ -84,7 +84,8 @@ void ScMyOLEFixer::CreateChartListener(ScDocument& rDoc, if (pRefTokens->empty()) return; - ScChartListener* pCL(new ScChartListener(rName, rDoc, std::move(pRefTokens))); + OUString sName = !rName.isEmpty() ? rName : pCollection->getUniqueName("OLEFixer "); + ScChartListener* pCL(new ScChartListener(sName, rDoc, std::move(pRefTokens))); //for loading binary files e.g. //if we have the flat filter we need to set the dirty flag thus the visible charts get repainted -- cgit v1.2.3