From 388014fc19b2a785f887cdfee91100fc9ab8d58d Mon Sep 17 00:00:00 2001 From: Eike Rathke Date: Mon, 19 Sep 2016 18:04:54 +0200 Subject: Resolves: tdf#100409 do not return coded double error for single matrix value Change-Id: I94477bf64ee7972e9822921a8a15d935cb01e53b --- sc/source/core/tool/interpr4.cxx | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index 5c39c81e2a12..09a4b8382d02 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -2021,14 +2021,36 @@ double ScInterpreter::GetDoubleFromMatrix(const ScMatrixRef& pMat) return 0.0; if ( !pJumpMatrix ) - return pMat->GetDoubleWithStringConversion( 0, 0); + { + double fVal = pMat->GetDoubleWithStringConversion( 0, 0); + sal_uInt16 nErr = GetDoubleErrorValue( fVal); + if (nErr) + { + // Do not propagate the coded double error, but set nGlobalError in + // case the matrix did not have an error interpreter set. + SetError( nErr); + fVal = 0.0; + } + return fVal; + } SCSIZE nCols, nRows, nC, nR; pMat->GetDimensions( nCols, nRows); pJumpMatrix->GetPos( nC, nR); // Use vector replication for single row/column arrays. if ( (nC < nCols || nCols == 1) && (nR < nRows || nRows == 1) ) - return pMat->GetDoubleWithStringConversion( nC, nR); + { + double fVal = pMat->GetDoubleWithStringConversion( nC, nR); + sal_uInt16 nErr = GetDoubleErrorValue( fVal); + if (nErr) + { + // Do not propagate the coded double error, but set nGlobalError in + // case the matrix did not have an error interpreter set. + SetError( nErr); + fVal = 0.0; + } + return fVal; + } SetError( errNoValue); return 0.0; -- cgit v1.2.3