From 18dc598a6e0017df375369a81c8df3bbd41ed8ab Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 18 May 2020 11:32:34 +0200 Subject: loplugin:unusedfields Change-Id: I8796c0937fe4b046d9a13e2e50368e45e0e45611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94404 Tested-by: Jenkins Reviewed-by: Noel Grandin --- .../unusedfields.only-used-in-constructor.results | 16 +++++++--------- compilerplugins/clang/unusedfields.readonly.results | 10 +++++++--- compilerplugins/clang/unusedfields.untouched.results | 20 ++++++++------------ compilerplugins/clang/unusedfields.writeonly.results | 18 +++++++++--------- vcl/source/control/combobox.cxx | 3 +-- 5 files changed, 32 insertions(+), 35 deletions(-) diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index 21177759ae59..bd57ae985122 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -9,9 +9,9 @@ avmedia/source/vlc/wrapper/Types.hxx:43 avmedia/source/vlc/wrapper/Types.hxx:44 libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char * avmedia/source/vlc/wrapper/Types.hxx:45 - libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:42:7) + libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:42:7) avmedia/source/vlc/wrapper/Types.hxx:46 - libvlc_event_t u union (anonymous union at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:40:5) + libvlc_event_t u union (anonymous union at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:40:5) avmedia/source/vlc/wrapper/Types.hxx:52 libvlc_track_description_t psz_name char * basegfx/source/polygon/b2dpolygontriangulator.cxx:112 @@ -86,8 +86,6 @@ cppcanvas/source/mtfrenderer/textaction.cxx:1641 cppcanvas::internal::(anonymous namespace)::OutlineAction maTextLineInfo const tools::TextLineInfo cppu/source/threadpool/threadpool.cxx:361 _uno_ThreadPool dummy sal_Int32 -cppu/source/typelib/typelib.cxx:60 - (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:38 (anonymous namespace)::C1 n1 sal_Int16 cppu/source/uno/check.cxx:67 @@ -120,6 +118,8 @@ cppu/source/uno/check.cxx:107 (anonymous namespace)::P p2 double cppu/source/uno/check.cxx:115 (anonymous namespace)::second a int +cppu/source/uno/check.cxx:120 + (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:126 (anonymous namespace)::Char1 c1 char cppu/source/uno/check.cxx:130 @@ -170,6 +170,8 @@ dbaccess/source/core/dataaccess/connection.hxx:102 dbaccess::OConnection m_nInAppend std::atomic dbaccess/source/core/inc/databasecontext.hxx:85 dbaccess::ODatabaseContext m_aBasicDLL class BasicDLL +desktop/qa/desktop_lib/test_desktop_lib.cxx:2782 + class AllSettings & drawinglayer/inc/texture/texture3d.hxx:61 drawinglayer::texture::GeoTexSvxBitmapEx maBitmap class Bitmap drawinglayer/inc/texture/texture3d.hxx:63 @@ -720,19 +722,15 @@ svx/source/xml/xmleohlp.cxx:68 OutputStorageWrapper_Impl aTempFile class utl::TempFile svx/source/xml/xmlgrhlp.cxx:87 (anonymous namespace)::GraphicInputStream maTempFile utl::TempFile -sw/inc/accessibilityoptions.hxx:25 - SwAccessibilityOptions bIsStopAnimatedText _Bool sw/inc/unosett.hxx:145 SwXNumberingRules m_pImpl ::sw::UnoImplPtr sw/qa/core/test_ToxTextGenerator.cxx:145 (anonymous namespace)::ToxTextGeneratorWithMockedChapterField mChapterFieldType class SwChapterFieldType -sw/qa/extras/layout/layout.cxx:2921 - class SvtSysLocaleOptions & sw/qa/extras/uiwriter/uiwriter.cxx:4214 (anonymous namespace)::IdleTask maIdle class Idle sw/source/core/crsr/crbm.cxx:64 (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState -sw/source/core/inc/swfont.hxx:987 +sw/source/core/inc/swfont.hxx:980 SvStatistics nGetStretchTextSize sal_uInt16 sw/source/core/layout/dbg_lay.cxx:171 SwImplEnterLeave nAction enum DbgAction diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index d995a856ab07..38f5b00b99ec 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -156,6 +156,8 @@ cppu/source/uno/check.cxx:107 (anonymous namespace)::P p2 double cppu/source/uno/check.cxx:115 (anonymous namespace)::second a int +cppu/source/uno/check.cxx:120 + (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:126 (anonymous namespace)::Char1 c1 char cppu/source/uno/check.cxx:130 @@ -335,7 +337,7 @@ include/svx/svdoedge.hxx:160 include/svx/svdpntv.hxx:160 SdrPaintView maDrawinglayerOpt class SvtOptionsDrawinglayer include/unoidl/unoidl.hxx:443 - unoidl::ConstantValue union unoidl::ConstantValue::(anonymous at /home/noel/libo2/include/unoidl/unoidl.hxx:443:5) + unoidl::ConstantValue union unoidl::ConstantValue::(anonymous at /home/noel/libo/include/unoidl/unoidl.hxx:443:5) include/unoidl/unoidl.hxx:444 unoidl::ConstantValue::(anonymous) booleanValue _Bool include/unoidl/unoidl.hxx:445 @@ -413,7 +415,7 @@ sc/inc/attarray.hxx:68 sc/inc/compiler.hxx:129 ScRawToken::(anonymous union)::(anonymous) eItem class ScTableRefToken::Item sc/inc/compiler.hxx:130 - ScRawToken::(anonymous) table struct (anonymous struct at /home/noel/libo2/sc/inc/compiler.hxx:127:9) + ScRawToken::(anonymous) table struct (anonymous struct at /home/noel/libo/sc/inc/compiler.hxx:127:9) sc/inc/compiler.hxx:135 ScRawToken::(anonymous) pMat class ScMatrix * sc/inc/formulagroup.hxx:39 @@ -924,6 +926,8 @@ vcl/inc/WidgetThemeLibrary.hxx:150 vcl::WidgetThemeLibrary_t updateSettings _Bool (*)(struct vcl::WidgetDrawStyle &) vcl/source/app/settings.cxx:196 ImplStyleData maDialogStyle struct DialogStyle +vcl/source/control/combobox.cxx:65 + ComboBox::Impl m_DoubleClickHdl Link vcl/source/control/roadmapwizard.cxx:62 vcl::RoadmapWizardImpl aStateDescriptors vcl::(anonymous namespace)::StateDescriptions vcl/source/control/tabctrl.cxx:79 @@ -1024,5 +1028,5 @@ xmloff/source/chart/SchXMLChartContext.hxx:56 SeriesDefaultsAndStyles maPercentageErrorDefault css::uno::Any xmloff/source/chart/SchXMLChartContext.hxx:57 SeriesDefaultsAndStyles maErrorMarginDefault css::uno::Any -xmloff/source/core/xmlexp.cxx:265 +xmloff/source/core/xmlexp.cxx:263 SvXMLExport_Impl maSaveOptions class SvtSaveOptions diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results index 4c5433c56759..2bbfd9204ba4 100644 --- a/compilerplugins/clang/unusedfields.untouched.results +++ b/compilerplugins/clang/unusedfields.untouched.results @@ -5,9 +5,9 @@ avmedia/source/vlc/wrapper/Types.hxx:43 avmedia/source/vlc/wrapper/Types.hxx:44 libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char * avmedia/source/vlc/wrapper/Types.hxx:45 - libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:42:7) + libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:42:7) avmedia/source/vlc/wrapper/Types.hxx:46 - libvlc_event_t u union (anonymous union at /home/noel/libo2/avmedia/source/vlc/wrapper/Types.hxx:40:5) + libvlc_event_t u union (anonymous union at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:40:5) avmedia/source/vlc/wrapper/Types.hxx:52 libvlc_track_description_t psz_name char * basctl/source/inc/dlged.hxx:122 @@ -34,12 +34,12 @@ connectivity/source/drivers/mork/MDatabaseMetaData.hxx:30 connectivity::mork::ODatabaseMetaData m_pMetaDataHelper std::unique_ptr cppu/source/threadpool/threadpool.cxx:361 _uno_ThreadPool dummy sal_Int32 -cppu/source/typelib/typelib.cxx:60 - (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 dbaccess/source/core/inc/databasecontext.hxx:85 dbaccess::ODatabaseContext m_aBasicDLL class BasicDLL dbaccess/source/sdbtools/inc/connectiondependent.hxx:115 sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard +desktop/qa/desktop_lib/test_desktop_lib.cxx:2782 + class AllSettings & emfio/source/emfuno/xemfparser.cxx:50 emfio::emfreader::(anonymous namespace)::XEmfParser context_ uno::Reference extensions/source/scanner/scanner.hxx:43 @@ -64,12 +64,12 @@ include/sfx2/msg.hxx:117 SfxType0 createSfxPoolItemFunc std::function include/sfx2/msg.hxx:119 SfxType0 nAttribs sal_uInt16 +include/sfx2/msg.hxx:132 + SfxType1 createSfxPoolItemFunc std::function include/sfx2/msg.hxx:132 SfxType1 pType const std::type_info * include/sfx2/msg.hxx:132 SfxType1 nAttribs sal_uInt16 -include/sfx2/msg.hxx:132 - SfxType1 createSfxPoolItemFunc std::function include/sfx2/msg.hxx:132 SfxType1 aAttrib struct SfxTypeAttrib [1] include/sfx2/msg.hxx:133 @@ -80,14 +80,14 @@ include/sfx2/msg.hxx:133 SfxType2 aAttrib struct SfxTypeAttrib [2] include/sfx2/msg.hxx:133 SfxType2 nAttribs sal_uInt16 -include/sfx2/msg.hxx:134 - SfxType3 aAttrib struct SfxTypeAttrib [3] include/sfx2/msg.hxx:134 SfxType3 pType const std::type_info * include/sfx2/msg.hxx:134 SfxType3 createSfxPoolItemFunc std::function include/sfx2/msg.hxx:134 SfxType3 nAttribs sal_uInt16 +include/sfx2/msg.hxx:134 + SfxType3 aAttrib struct SfxTypeAttrib [3] include/sfx2/msg.hxx:135 SfxType4 aAttrib struct SfxTypeAttrib [4] include/sfx2/msg.hxx:135 @@ -378,10 +378,6 @@ svx/source/dialog/weldeditview.cxx:312 (anonymous namespace)::WeldEditSource m_rEditAcc class WeldEditAccessible & svx/source/tbxctrls/layctrl.cxx:434 (anonymous namespace)::ColumnsWindow mxControl rtl::Reference -sw/inc/accessibilityoptions.hxx:25 - SwAccessibilityOptions bIsStopAnimatedText _Bool -sw/qa/extras/layout/layout.cxx:2921 - class SvtSysLocaleOptions & sw/source/core/crsr/crbm.cxx:64 (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState sw/source/core/frmedt/fetab.cxx:75 diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results index f7be335be21a..9c3b323a714f 100644 --- a/compilerplugins/clang/unusedfields.writeonly.results +++ b/compilerplugins/clang/unusedfields.writeonly.results @@ -204,6 +204,8 @@ cppu/source/uno/check.cxx:107 (anonymous namespace)::P p2 double cppu/source/uno/check.cxx:115 (anonymous namespace)::second a int +cppu/source/uno/check.cxx:120 + (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16 cppu/source/uno/check.cxx:126 (anonymous namespace)::Char1 c1 char cppu/source/uno/check.cxx:130 @@ -464,7 +466,7 @@ io/source/stm/odata.cxx:244 io_stm::(anonymous namespace)::ODataInputStream::readDouble()::(anonymous union)::(anonymous) n2 sal_uInt32 io/source/stm/odata.cxx:244 io_stm::(anonymous namespace)::ODataInputStream::readDouble()::(anonymous union)::(anonymous) n1 sal_uInt32 -jvmfwk/inc/vendorbase.hxx:174 +jvmfwk/inc/vendorbase.hxx:173 jfw_plugin::VendorBase m_sArch class rtl::OUString l10ntools/inc/common.hxx:31 common::HandledArgs m_bUTF8BOM _Bool @@ -868,17 +870,15 @@ sw/inc/unoframe.hxx:311 SwXOLEListener m_xOLEModel css::uno::Reference sw/inc/view.hxx:182 SwView m_xGlueDocShell std::unique_ptr -sw/source/core/inc/swfont.hxx:166 - SwFont m_bBlink _Bool -sw/source/core/inc/swfont.hxx:985 +sw/source/core/inc/swfont.hxx:978 SvStatistics nGetTextSize sal_uInt16 -sw/source/core/inc/swfont.hxx:986 +sw/source/core/inc/swfont.hxx:979 SvStatistics nDrawText sal_uInt16 -sw/source/core/inc/swfont.hxx:987 +sw/source/core/inc/swfont.hxx:980 SvStatistics nGetStretchTextSize sal_uInt16 -sw/source/core/inc/swfont.hxx:988 +sw/source/core/inc/swfont.hxx:981 SvStatistics nDrawStretchText sal_uInt16 -sw/source/core/inc/swfont.hxx:989 +sw/source/core/inc/swfont.hxx:982 SvStatistics nChangeFont sal_uInt16 sw/source/core/inc/unoflatpara.hxx:134 SwXFlatParagraphIterator m_aFlatParaList std::set > @@ -897,7 +897,7 @@ sw/source/filter/inc/rtf.hxx:29 sw/source/filter/inc/rtf.hxx:30 RTFSurround::(anonymous union)::(anonymous) nJunk sal_uInt8 sw/source/filter/inc/rtf.hxx:31 - RTFSurround::(anonymous) Flags struct (anonymous struct at /home/noel/libo2/sw/source/filter/inc/rtf.hxx:27:9) + RTFSurround::(anonymous) Flags struct (anonymous struct at /home/noel/libo/sw/source/filter/inc/rtf.hxx:27:9) sw/source/uibase/inc/glossary.hxx:63 SwGlossaryDlg m_xGroupData std::vector > sw/source/uibase/inc/maildispatcher.hxx:146 diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx index 72d07497c802..6ae400fc74b4 100644 --- a/vcl/source/control/combobox.cxx +++ b/vcl/source/control/combobox.cxx @@ -62,7 +62,6 @@ struct ComboBox::Impl sal_Int32 m_nMaxWidthChars; sal_Int32 m_nWidthInChars; Link m_SelectHdl; - Link m_DoubleClickHdl; explicit Impl(ComboBox & rThis) : m_rThis(rThis) @@ -506,7 +505,7 @@ void ComboBox::Select() void ComboBox::DoubleClick() { - ImplCallEventListenersAndHandler( VclEventId::ComboboxDoubleClick, [this] () { m_pImpl->m_DoubleClickHdl.Call(*this); } ); + ImplCallEventListenersAndHandler( VclEventId::ComboboxDoubleClick, [] () {} ); } bool ComboBox::IsAutoSizeEnabled() const { return m_pImpl->m_isDDAutoSize; } -- cgit v1.2.3