From 0c5048143054e973f5cb945ddd61d50fa1aac0ab Mon Sep 17 00:00:00 2001 From: Michael Stahl Date: Fri, 11 Mar 2022 17:29:41 +0100 Subject: hwpfilter: why isn't that path string null terminated MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit 4c86ed851bc1c0a2414e254082064760c99437f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131589 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara (cherry picked from commit dc566a7f687a728311490b5f4f624897f0aefd1d) --- hwpfilter/source/hwpread.cxx | 1 + 1 file changed, 1 insertion(+) diff --git a/hwpfilter/source/hwpread.cxx b/hwpfilter/source/hwpread.cxx index 1ef27f7c243f..7e0564b187a4 100644 --- a/hwpfilter/source/hwpread.cxx +++ b/hwpfilter/source/hwpread.cxx @@ -426,6 +426,7 @@ bool Picture::Read(HWPFile & hwpf) scale[1] = tmp16; hwpf.ReadBlock(picinfo.picun.path, 256); /* Picture File Name: when type is not a Drawing. */ + picinfo.picun.path[255] = 0; // ensure null terminated hwpf.ReadBlock(reserved3, 9); /* Brightness / Contrast / Picture Effect, etc. */ UpdateBBox(this); -- cgit v1.2.3