path: root/xmlsecurity/inc/documentsignaturemanager.hxx
AgeCommit message (Collapse)AuthorFilesLines
2018-05-22tdf#83877 Add valid/invalid images to signaturesSamuel Mehrbrodt1-1/+6
Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Samuel Mehrbrodt <>
2018-05-18tdf#83877 Write SignatureLineId to ODF & OOXML signaturesSamuel Mehrbrodt1-1/+2
Change-Id: I483a3b7895cdcb10ef9d6dacf167ed0f8db7e723 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Samuel Mehrbrodt <>
2018-01-04tdf#42949 Fix some more Include What You Use warningsMiklos Vajna1-1/+2
Change-Id: I2040315707674dc99a37aedb96ac61dca274c13a Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2018-01-03Turn on clang-format for these filesMiklos Vajna1-4/+5
I (tried to) keep these files consistent locally with astyle in the past, switching to clang-format makes sure that the recent problem with introducing inconsistencies with automatic loplugin rewrites doesn't happen again. Change-Id: If49c96b6e9e6ed50beb69c70e37125dff5607f76 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2018-01-02loplugin:passstuffbyref improved return in swNoel Grandin1-2/+2
Change-Id: I4484ac461761e4c46364b4f473c7e62f8ec72103 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2017-10-23loplugin:includeform: xmlsecurityStephan Bergmann1-3/+3
Change-Id: I9c3eca51fec52a255fcf280fe4e5ecc2ebbee5f3
2017-09-06xmlsecurity: no need to have pdfio/pdfdocument.hxx as a global headerMiklos Vajna1-1/+1
Which means xmlsecurity can be again a module that has no public headers. Change-Id: I3d0b03680398f80196fac187263e770fd44ed0ed Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2017-09-01xmlsecurity: fix inconsistent param naming in interface/implementationMiklos Vajna1-1/+1
Don't talk about enumeration when it's a number. Change-Id: I756063534b38478c382eaf72829091a4e27a6c4f Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2017-07-17svl: move byte-array verification from vclAshod Nakashian1-1/+1
Also use comphelper::Base64 and DateTime::CreateFromUnixTime to avoid depending on sax. Change-Id: If1853f8d9481c9caa0625a111707531bbc495f75 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Ashod Nakashian <>
2017-06-22xmlsecurity: fix loplugin:passstuffbyref warningsMiklos Vajna1-1/+1
Change-Id: I627abfe33e9c2fc4243276706c1624ce19943678
2017-06-21gpg4libre: Make signature dialog work with two signing servicesSamuel Mehrbrodt1-1/+5
Change-Id: I0b47e6dba38222bb6b4f778c4206d3b37bc93089
2017-03-04gpg4libre: List and view GPG keysSamuel Mehrbrodt1-0/+3
* Add GPG implementation of css::xml::crypto UNO interfaces (part of that is only stub atm) * List gpg keys along with other certificates * Viewing gpg certificates: Not all properties are implemented yet Change-Id: I7f60b26efe949a94bf8fe1b8d4d428002c2995b1 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Siegmund Gorr <> Reviewed-by: Thorsten Behrens <>
2017-02-24vcl: add initial CppunitTest_vcl_pdfexportMiklos Vajna1-1/+1
Invoke the PDF export filter and then use the PDF tokenizer from xmlsecurity to assert the contents of created PDF file. The testcase fails with commit 6db0f1feb1d9931d2726dd11a889c58815710ce0 (tdf#106059 PDF export: create a reference XObject for PDF images, 2017-02-22) reverted. Change-Id: I90526fef41d9560ae447f586df766bc50a491c43 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-11-17xmlsecurity PDF sign: handle AdES when writing SubFilterMiklos Vajna1-1/+1
Page 21 of "PAdES baseline signatures" specification from <> says: "The Signature Dictionary shall contain a value of ETSI.CAdES.detached for the key SubFilter." So in case the UI has the adescompliant checkbox enabled, write that value instead of the Adobe default. Change-Id: I69e606a32fb09bebd5e9b25b32150d1b8672f544
2016-11-10More work in progress on XAdES compliant ODF signingTor Lillqvist1-1/+1
Pass an XAdES flag to a couple more functions and adapt to that. Factor out writeDigestMethod() and writeSignedProperties() from OOXMLSecExporter::Impl to DocumentSignatureHelper and use them in an additional place. Write xd:UnsignedProperties with EncapsulatedX509Certificate. Probably much more work needed. Change-Id: I2a0cd1db6dd487b9c7ba256ad29473de3d271cd8
2016-11-08xmlsecurity: move the sec context from the format helpers to the sign managerMiklos Vajna1-0/+6
The signature manager always creates an XML helper, and optionally creates a PDF helper as well. Both of them initialize xmlsec, and when the signature manager is deleted, there are two de-inits, leading to an assertion failure in xmlsec. Fix the problem by moving the duplicated xmlsec init to the signature manager. This has the additional benefit that general security-related code no longer has to talk to the XML helper, it can use the signature manager, which feels more natural. (What viewing a certificate had to do with XML?) Change-Id: If6a6bc433636445f3782849a367d4a7ac0be7688 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-11-08Work in progress on supporting XAdES-compliant signatures for ODFTor Lillqvist1-1/+5
xmlsecurity is such a mess. Too many different classes that actually have more or less identical life-time, with names that smell of delusions of grandeur. "Manager", "security framework controller" etc for stuff that actually exist only during the execution of a simple dialog. And then a "helper" class that actually in on a higher level than a "framework controller". But oh well. Change-Id: I86e461b1bc91a0d8f5b7fb9f13a5be201729df1e
2016-10-13xmlsecuity: show PDF signature in the doc signatures dialogMiklos Vajna1-0/+7
It doesn't actually show any details yet, but it shows a selectable empty line, to be filled in with details. Change-Id: Ib35f13e5c779fe1a28933c1a0761682e9f5de62d Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Miklos Vajna <>
2016-05-27Get rid of unnecessary directory levels $D/inc/$DTor Lillqvist1-4/+4
Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Tor Lillqvist <> Tested-by: Tor Lillqvist <>
2016-03-07xmlsecurity: extract final signature export logic from DigitalSignaturesDialogMiklos Vajna1-0/+2
To be able to unit-test this later without creating a vcl dialog. Change-Id: I4794e212ffefc2efa3bddaf58e6c6bf2a4ea8d9a
2016-03-04xmlsecurity: extract signature removal logic from DigitalSignaturesDialogMiklos Vajna1-0/+2
So that it'll be possible to call that code without an active dialog, from a headless unit test. Change-Id: I1728a666ff5d84b337efd7e2b7eb68469896257a
2016-03-04xmlsecurity OOXML export: only cache existing signatures, not our temp. oneMiklos Vajna1-1/+1
When adding a signature, first we export it to a temp. storage, then read it back, show the verification to the user, and then later we do or do not write the temp. storage back to the original one. This means the signature gets exported two times, and MSO only considers the final result valid. So when caching signatures (to avoid a real export based on our data model), don't cache the one we just added to the temp. storage, but do a real export second time as well. With this, MSO considers our appended signature (next to an existing one) valid, too. Change-Id: I4d615298463e037ea4e654ff5c3addcef8b0a094
2016-02-15xmlsecurity: factor out DocumentSignatureManager from DigitalSignaturesDialogMiklos Vajna1-0/+62
It's hard to unit test signing when the logic is implemented in the Add and OK button handlers. Change-Id: I5e07df69cd808cf170e21dfd55f2f44bc79c58a8